Merge pull request DesignPatternsPHP#108 from dan-lyn/master

Dominik Liebler · Dominik Liebler · commit 37cdbd6c2332 · 2014-08-30T16:06:46.000+02:00
fixed typos and trailing slashes
diff --git a/Behavioral/ChainOfResponsibilities/Handler.php b/Behavioral/ChainOfResponsibilities/Handler.php
@@ -4,9 +4,9 @@
 
 /**
  * Handler is a generic handler in the chain of responsibilities
- * 
- * Yes you could have a lighter CoR with simpler handler but if you want your CoR to
- * be extendable and decoupled, it's a better idea to do things like that in real
+ *
+ * Yes you could have a lighter CoR with a simpler handler but if you want your CoR
+ * to be extendable and decoupled, it's a better idea to do things like that in real
  * situations. Usually, a CoR is meant to be changed everytime and evolves, that's
  * why we slice the workflow in little bits of code.
  */
@@ -19,13 +19,13 @@ abstract class Handler
 
     /**
      * Append a responsibility to the end of chain
-     * 
+     *
      * A prepend method could be done with the same spirit
-     * 
-     * You could also send the successor in the constructor but in PHP it is a
+     *
+     * You could also send the successor in the constructor but in PHP that is a
      * bad idea because you have to remove the type-hint of the parameter because
      * the last handler has a null successor.
-     * 
+     *
      * And if you override the constructor, that Handler can no longer have a
      * successor. One solution is to provide a NullObject (see pattern).
      * It is more preferable to keep the constructor "free" to inject services
@@ -43,10 +43,10 @@ final public function append(Handler $handler)
     }
 
     /**
-     * Handle the request. 
-     * 
-     * This approach by using a template method pattern ensures you that 
-     * each subclass will not forget to call the successor. Beside, the returned
+     * Handle the request.
+     *
+     * This approach by using a template method pattern ensures you that
+     * each subclass will not forget to call the successor. Besides, the returned
      * boolean value indicates you if the request have been processed or not.
      *
      * @param Request $req
diff --git a/Behavioral/ChainOfResponsibilities/Request.php b/Behavioral/ChainOfResponsibilities/Request.php
@@ -4,14 +4,14 @@
 
 /**
  * Request is a request which goes through the chain of responsibilities.
- * 
- * About the request : Sometimes, you don't need an object, just an integer or
- * an array. But in this case of a full example, I've made a class to illustrate 
- * this important idea in the CoR (Chain of Responsibilities). In real world,
+ *
+ * About the request: Sometimes, you don't need an object, just an integer or
+ * an array. But in this case of a full example, I've made a class to illustrate
+ * this important idea in the CoR (Chain of Responsibilities). In the real world,
  * I recommend to always use a class, even a \stdClass if you want, it proves
  * to be more adaptive because a single handler doesn't know much about the
  * outside world and it is more difficult if, one day, you want to add some
- * criterion in a decision process. 
+ * criterion in a decision process.
  */
 class Request
 {
diff --git a/Behavioral/ChainOfResponsibilities/Responsible/SlowStorage.php b/Behavioral/ChainOfResponsibilities/Responsible/SlowStorage.php
@@ -7,13 +7,13 @@
 
 /**
  * This is mostly the same code as FastStorage but in fact, it may greatly differs
- * 
- * One important fact about CoR : each item in the chain MUST NOT assume its position
+ *
+ * One important fact about CoR: each item in the chain MUST NOT assume its position
  * in the chain. A CoR is not responsible if the request is not handled UNLESS
  * you make an "ExceptionHandler" which throws execption if the request goes there.
- * 
- * To be really extendable, each handler doesn't know if there is something after him.
- * 
+ *
+ * To be really extendable, each handler doesn't know if there is something after it.
+ *
  */
 class SlowStorage extends Handler
 {
diff --git a/Behavioral/ChainOfResponsibilities/Tests/ChainTest.php b/Behavioral/ChainOfResponsibilities/Tests/ChainTest.php
@@ -28,6 +28,7 @@ public function makeRequest()
     {
         $request = new Request();
         $request->verb = 'get';
+
         return array(
             array($request)
         );
diff --git a/Behavioral/TemplateMethod/Journey.php b/Behavioral/TemplateMethod/Journey.php
@@ -37,7 +37,7 @@ protected function buyGift()
     }
 
     /**
-     * this method will be unknown by subclasses (better)
+     * This method will be unknown by subclasses (better)
      */
     private function buyAFlight()
     {
diff --git a/Creational/Pool/Tests/PoolTest.php b/Creational/Pool/Tests/PoolTest.php
@@ -6,7 +6,6 @@
 
 class TestWorker
 {
-
     public $id = 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ public function makeRequest()`
`28`	`28`	`{`
`29`	`29`	`$request = new Request();`
`30`	`30`	`$request->verb = 'get';`
	`31`	`+`
`31`	`32`	`return array(`
`32`	`33`	`array($request)`
`33`	`34`	`);`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ protected function buyGift()`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`/**`
`40`		`- * this method will be unknown by subclasses (better)`
	`40`	`+ * This method will be unknown by subclasses (better)`
`41`	`41`	`*/`
`42`	`42`	`private function buyAFlight()`
`43`	`43`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@`
`6`	`6`
`7`	`7`	`class TestWorker`
`8`	`8`	`{`
`9`		`-`
`10`	`9`	`public $id = 1;`
`11`	`10`	`}`
`12`	`11`