Skip to content

Fix incorrect worksheet.state #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix incorrect worksheet.state #666

wants to merge 1 commit into from

Conversation

DaSpawn
Copy link

@DaSpawn DaSpawn commented Oct 16, 2018

corrects #617: worksheet.state was incorrect with a value of 'show', requires 'visible'.

corrects #617:  worksheet.state was incorrect with a value of 'show', requires 'visible'.
@felipesilvati
Copy link

felipesilvati commented Dec 12, 2018

Great contribution, @DaSpawn ! In addition to that, please emphasize that if you intend to add more than one worksheet, all other worksheets must be set to visible, or you'll get a workbook with only the first worksheet appearing.

BTW: Isn't it weird that the standard exceljs behavior is to add worksheets in a hidden state?

@adam-beck-sb
Copy link

Should be an easy one to get merged in. Thanks @DaSpawn! Unfortunately, I found this fix before figuring it out myself.

@Siemienik
Copy link
Member

#621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants