Skip to content

Review the CorrectFactor #788

@jabrena

Description

@jabrena

Reviewing the GenericMode, I made few questions:

  • Is it necessary the CorrectFactor?
  • Is it necessary to return 0?

https://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/master/src/main/java/ev3dev/sensors/GenericMode.java

            reading *= correctFactor;
            if (reading < correctMin) {
                reading = 0;
            } else if (reading >= correctMax) {
                reading = Float.POSITIVE_INFINITY;
            }
  • Review consumers and the effect to remove correctFactor & return reading = Float.NEGATIVE_INFINITY

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions