Improve logging

CompuIves · CompuIves · commit 144dc142a31e · 2020-02-29T01:27:02.000+01:00
diff --git a/packages/app/src/app/overmind/effects/live/index.ts b/packages/app/src/app/overmind/effects/live/index.ts
@@ -10,6 +10,7 @@ import { TextOperation } from 'ot';
 import { Socket, Channel } from 'phoenix';
 import uuid from 'uuid';
 
+import { logBreadcrumb } from '@codesandbox/common/lib/utils/analytics/sentry';
 import clientsFactory from './clients';
 import { OPTIMISTIC_ID_PREFIX } from '../utils';
 
@@ -44,12 +45,22 @@ export default new (class Live {
     const live = this;
 
     clients = clientsFactory(
-      (moduleShortid, revision, operation) =>
-        live.send('operation', {
+      (moduleShortid, revision, operation) => {
+        logBreadcrumb({
+          type: 'ot',
+          message: `Sending ${JSON.stringify({
+            moduleShortid,
+            revision,
+            operation,
+          })}`,
+        });
+
+        return live.send('operation', {
           moduleShortid,
           operation,
           revision,
-        }),
+        });
+      },
       (moduleShortid, operation) => {
         options.onApplyOperation({
           moduleShortid,
@@ -143,6 +154,11 @@ export default new (class Live {
         data && data._messageId && sentMessages.delete(data._messageId)
       );
 
+      if (event === 'phx_reply' || event.startsWith('chan_reply_')) {
+        // No action listens to this
+        return data;
+      }
+
       action({
         event: alteredEvent,
         _isOwnMessage,
diff --git a/packages/app/src/app/overmind/namespaces/live/liveMessageOperators.ts b/packages/app/src/app/overmind/namespaces/live/liveMessageOperators.ts
@@ -11,6 +11,7 @@ import { NotificationStatus } from '@codesandbox/notifications/lib/state';
 import { Operator } from 'app/overmind';
 import { camelizeKeys } from 'humps';
 import { json, mutate } from 'overmind';
+import { logError } from '@codesandbox/common/lib/utils/analytics';
 
 export const onJoin: Operator<LiveMessage<{
   status: 'connected';
@@ -490,6 +491,9 @@ export const onOperation: Operator<LiveMessage<{
     } catch (e) {
       // Something went wrong, probably a sync mismatch. Request new version
       console.error('Something went wrong with applying OT operation');
+
+      logError(e);
+
       effects.live.sendModuleStateSyncRequest();
     }
   }
