Fixed #36369: Added tests to verify FORWARD_PROPERTIES and REVERSE_PROPERTIES cache behaviours. #19645
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| except Exception as e: | ||
| self.fail(f"Failed to access cached property '{attr_name}': {e}") | ||
|
|
||
| opts._expire_cache() |
There was a problem hiding this comment.
There was a previous comment about avoiding internal functions, but unfortunately, I can’t use apps.clear_cache() — the tests fail because it doesn’t actually clear any caches when used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
Ticket-36369
Branch description
What: This PR adds unit tests for FORWARD_PROPERTIES and REVERSE_PROPERTIES.
Why: Based on the discussions in this ticket and this #19245, it was obvious that unit tests were missing for FORWARD_PROPERTIES and REVERSE_PROPERTIES in models/options.py.
Main update: Introduced a new test file, test_meta_caching.py, containing unit tests focused on testing that the correct caches are expired when the interface to clear them (apps.clear_cache()) is called, specifically targeting REVERSE_PROPERTIES and FORWARD_PROPERTIES.
Checklist
This PR targets the main branch.
The commit message is written in past tense, mentions the ticket number, and ends with a period.
I have checked the "Has patch" ticket flag in the Trac system.
I have added or updated relevant tests.
[N/A] I have added or updated relevant docs, including release notes if applicable.
[N/A] I have attached screenshots in both light and dark modes for any UI changes.