Skip to content

Skipped test_no_logs_without_debug test when the runner is invoked with --debug-sql. #19493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2025
Merged

Skipped test_no_logs_without_debug test when the runner is invoked with --debug-sql. #19493

merged 1 commit into from
Jul 13, 2025

Conversation

jacobtylerwalls
Copy link
Member

Branch description

As alluded to as an aside in ticket-36112, this command fails (since --debug-sql unconditionally logs SQL queries, and this test tests that sql queries are not logged when DEBUG=False):

./runtests.py backends.base.test_base.DatabaseWrapperLoggingTests.test_no_logs_without_debug --debug-sql

(Let me know if I should Refs #..., but it seemed tangential.)

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label May 22, 2025
@felixxm felixxm changed the title Skipped a test when the runner is invoked with --debug-sql. Skipped test_no_logs_without_debug test when the runner is invoked with --debug-sql. Jul 13, 2025
felixxm
felixxm approved these changes Jul 13, 2025
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobtylerwalls Thanks 👍

@felixxm felixxm merged commit 43c6804 into django:main Jul 13, 2025
32 of 33 checks passed
@jacobtylerwalls jacobtylerwalls deleted the debug-sql-skip-test branch July 13, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm approved these changes

Assignees
No one assigned
Labels
no ticket Based on PR title, no linked Trac ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @felixxm