Support GHC 9.10 #218
Merged
Support GHC 9.10 #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foldl' has been added to Prelude in GHC 9.10, which makes the explicit import of Data.Foldable (foldl') redundant in the gateway cache module. We can't just remove the import line since it's needed for GHC < 9.10, so we employ the workaround documented here: haskell/core-libraries-committee#167 By hiding Foldable(..) from Prelude in all versions, we always import the foldl' from Data.Foldable.
L0neGamer
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new base version as supported, and a tested-with clause for GHC 9.10 for Hackage visibility and the CI matrix.
Although that was enough to build on GHC 9.10, for future-proofness I've also bumped the upper bounds for dependencies where possible since the changelogs for the bumps didn't affect us.