Short circuit after filtering out already searched DNs

mtodd · mtodd · commit 52654ad40bd9 · 2015-01-15T13:56:13.000-08:00
diff --git a/lib/github/ldap/member_search/recursive.rb b/lib/github/ldap/member_search/recursive.rb
@@ -69,12 +69,12 @@ def perform(group)
                 sub_dns.concat member_dns(subgroup)
               end
 
-              # give up if there's nothing else to search for
-              break if sub_dns.empty?
-
               # filter out if already searched for
               sub_dns.reject! { |dn| searched.include?(dn) }
 
+              # give up if there's nothing else to search for
+              break if sub_dns.empty?
+
               # search for subgroups
               subgroups = sub_dns.each_with_object([]) do |dn, subgroups|
                 subgroups.concat ldap.search(base: dn, scope: Net::LDAP::SearchScope_BaseObject, attributes: attrs, filter: filter)
