Skip to content

fix: Updated getting of version #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Conversation

yaroslav8765
Copy link

No description provided.

@yaroslav8765 yaroslav8765 requested a review from SerVitasik July 15, 2025 10:38
}

if (version.includes('next')) {
console.log("Installing next version of AdminForth");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove log

console.log("Installing next version of AdminForth");
return 'next';
}
console.log("Installing latest version of AdminForth");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

const getAdminforthVersion = detectAdminforthVersion();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adminforthVersion


const execAsync = promisify(exec);


function getVersion() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't repeat yourself

@yaroslav8765 yaroslav8765 requested a review from SerVitasik July 15, 2025 11:03
@SerVitasik SerVitasik merged commit bde97e2 into next Jul 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants