refactor 362

fishercoder1534 · fishercoder1534 · commit 121b291d2b35 · 2017-09-22T07:43:57.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_362.java b/src/main/java/com/fishercoder/solutions/_362.java
@@ -1,7 +1,12 @@
 package com.fishercoder.solutions;
-/**Design a hit counter which counts the number of hits received in the past 5 minutes.
+/**
+ * 362. Design Hit Counter
+ *
+ * Design a hit counter which counts the number of hits received in the past 5 minutes.
 
- Each function accepts a timestamp parameter (in seconds granularity) and you may assume that calls are being made to the system in chronological order (ie, the timestamp is monotonically increasing). You may assume that the earliest timestamp starts at 1.
+ Each function accepts a timestamp parameter (in seconds granularity) and you may assume
+ that calls are being made to the system in chronological order (ie, the timestamp is monotonically increasing).
+ You may assume that the earliest timestamp starts at 1.
 
  It is possible that several hits arrive roughly at the same time.
 
@@ -29,55 +34,60 @@ Each function accepts a timestamp parameter (in seconds granularity) and you may
  // get hits at timestamp 301, should return 3.
  counter.getHits(301);
  Follow up:
- What if the number of hits per second could be very large? Does your design scale?*/
+ What if the number of hits per second could be very large? Does your design scale?
+ */
+
 public class _362 {
 
-    class HitCounter {
-        /**
-         * Looked at this post: https://discuss.leetcode.com/topic/48758/super-easy-design-o-1-hit-o-s-gethits-no-fancy-data-structure-is-needed,
-         * I added one more field k to make it more generic.
-         */
-        private int[] times;
-        private int[] hits;
-        private int k;
+    public static class Solution1 {
+        public static class HitCounter {
+            /**
+             * Reference: https://discuss.leetcode.com/topic/48758/super-easy-design-o-1-hit-o-s-gethits-no-fancy-data-structure-is-needed,
+             * I added one more field k to make it more generic.
+             * It basically maintains a window of size 300, use modular to update the index.
+             */
+            private int[] times;
+            private int[] hits;
+            private int k;
 
-        /**
-         * Initialize your data structure here.
-         */
-        public HitCounter() {
-            k = 300;
-            times = new int[k];
-            hits = new int[k];
-        }
+            /**
+             * Initialize your data structure here.
+             */
+            public HitCounter() {
+                k = 300;
+                times = new int[k];
+                hits = new int[k];
+            }
 
-        /**
-         * Record a hit.
-         *
-         * @param timestamp - The current timestamp (in seconds granularity).
-         */
-        public void hit(int timestamp) {
-            int index = timestamp % k;
-            if (times[index] != timestamp) {
-                times[index] = timestamp;
-                hits[index] = 1;
-            } else {
-                hits[index]++;
+            /**
+             * Record a hit.
+             *
+             * @param timestamp - The current timestamp (in seconds granularity).
+             */
+            public void hit(int timestamp) {
+                int index = timestamp % k;
+                if (times[index] != timestamp) {
+                    times[index] = timestamp;
+                    hits[index] = 1;
+                } else {
+                    hits[index]++;
+                }
             }
-        }
 
-        /**
-         * Return the number of hits in the past 5 minutes.
-         *
-         * @param timestamp - The current timestamp (in seconds granularity).
-         */
-        public int getHits(int timestamp) {
-            int total = 0;
-            for (int i = 0; i < k; i++) {
-                if (timestamp - times[i] < k) {
-                    total += hits[i];
+            /**
+             * Return the number of hits in the past 5 minutes.
+             *
+             * @param timestamp - The current timestamp (in seconds granularity).
+             */
+            public int getHits(int timestamp) {
+                int total = 0;
+                for (int i = 0; i < k; i++) {
+                    if (timestamp - times[i] < k) {
+                        total += hits[i];
+                    }
                 }
+                return total;
             }
-            return total;
         }
     }
 }
diff --git a/src/test/java/com/fishercoder/_362Test.java b/src/test/java/com/fishercoder/_362Test.java
@@ -0,0 +1,32 @@
+package com.fishercoder;
+
+import com.fishercoder.solutions._362;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class _362Test {
+    private static _362.Solution1.HitCounter hitCounter;
+
+    @BeforeClass
+    public static void setup() {
+        hitCounter = new _362.Solution1.HitCounter();
+    }
+
+    @Test
+    public void test1() {
+        hitCounter.hit(1);
+        hitCounter.hit(2);
+        hitCounter.hit(3);
+        assertEquals(3, hitCounter.getHits(4));
+
+        hitCounter.hit(300);
+        assertEquals(4, hitCounter.getHits(300));
+        assertEquals(3, hitCounter.getHits(301));
+
+        hitCounter.hit(301);
+        assertEquals(4, hitCounter.getHits(300));
+    }
+
+}
