Skip to content

Document client options #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2016
Merged

Document client options #613

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f21623
Add doxygen documentation for client options
deanberris Mar 8, 2016
1e7c0e7
Use Doxygen-generated Documentation
deanberris Mar 8, 2016
7c6c708
Update generated HTTP client docs
deanberris Mar 8, 2016
6608f74
Default true to always_verify_peer
deanberris Mar 8, 2016
d9ed6d9
Update generated docs for HTTP client
deanberris Mar 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Default true to always_verify_peer
  • Loading branch information
@deanberris
deanberris committed Mar 8, 2016
commit 6608f740bee82ebcd1596fe2e4f250336ed990d4
4 changes: 3 additions & 1 deletion boost/network/protocol/http/client/options.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class client_options {
openssl_sni_hostname_(),
openssl_options_(0),
io_service_(),
always_verify_peer_(false),
always_verify_peer_(true),
timeout_(0) {}

client_options(client_options const& other)
Expand Down Expand Up @@ -141,6 +141,8 @@ class client_options {

/// Set whether we always verify the peer on the other side of the HTTPS
/// connection.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a:

/// Default: true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done -- and now changed the default to actually true (!!!?).

///
/// Default: true.
client_options& always_verify_peer(bool v) {
always_verify_peer_ = v;
return *this;
Expand Down