Skip to content

Fix #499 - Parsing empty query parameters #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2015
Merged

Fix #499 - Parsing empty query parameters #519

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63438e9
Fix #499 - Parsing empty query parameters
leecoder Apr 14, 2015
e7a88ad
boost build fix for travis-ci
leecoder Apr 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix #499 - Parsing empty query parameters
  • Loading branch information
@leecoder
leecoder committed Apr 14, 2015
commit 63438e9f68f644f5fb42d4eedb59d0f275a94826
2 changes: 1 addition & 1 deletion boost/network/uri/accessors.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ struct key_value_sequence : spirit::qi::grammar<uri::const_iterator, Map()> {
pair = key >> -('=' >> value);
key =
spirit::qi::char_("a-zA-Z_") >> *spirit::qi::char_("-+.~a-zA-Z_0-9/%");
value = +spirit::qi::char_("-+.~a-zA-Z_0-9/%");
value = *spirit::qi::char_("-+.~a-zA-Z_0-9/%");
}

spirit::qi::rule<uri::const_iterator, Map()> query;
Expand Down
13 changes: 13 additions & 0 deletions libs/network/test/uri/uri_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,3 +566,16 @@ BOOST_AUTO_TEST_CASE(issue_447_test) {
uri::uri instance("http://[www.foo.com/");
BOOST_REQUIRE(!uri::valid(instance));
}

BOOST_AUTO_TEST_CASE(issue_499_test) {
uri::uri instance(
"http://www.example.com/path?param1&param2=&param3=value");
BOOST_REQUIRE(uri::valid(instance));

std::map<std::string, std::string> queries;
uri::query_map(instance, queries);
BOOST_REQUIRE_EQUAL(queries.size(), std::size_t(3));
BOOST_CHECK_EQUAL(queries["param1"], "");
BOOST_CHECK_EQUAL(queries["param2"], "");
BOOST_CHECK_EQUAL(queries["param3"], "value");
}