Skip to content

Fixed compilation warnings. #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2014
Merged

Fixed compilation warnings. #465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e5607f
Supressed unused variable warning.
povilasb Nov 7, 2014
f1f4a43
Refactored code.
povilasb Nov 7, 2014
03efd34
Supressed unused parameter warnings.
povilasb Nov 7, 2014
7b93773
Added todo notes for dberris to review supressed unused parameter war…
povilasb Nov 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Supressed unused parameter warnings.
  • Loading branch information
@povilasb
povilasb committed Nov 7, 2014
commit 03efd34e480ce6ea4ca04a0962ea5d0b327a9296
2 changes: 2 additions & 0 deletions boost/network/protocol/http/client/connection/async_normal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ struct http_async_connection
body_generator_function_type generator,
boost::system::error_code const& ec,
std::size_t bytes_transferred) {
(void)bytes_transferred;

if (!is_timedout_ && !ec) {
if (generator) {
// Here we write some more data that the generator provides,
Expand Down
2 changes: 2 additions & 0 deletions boost/network/protocol/http/client/connection/async_protocol_handler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ struct http_async_protocol_handler {

template <class ResponseType>
void init_response(ResponseType& response_, bool get_body) {
(void)get_body;

boost::shared_future<string_type> source_future(
source_promise.get_future());
source(response_, source_future);
Expand Down
4 changes: 4 additions & 0 deletions boost/network/protocol/http/client/connection/sync_base.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,17 @@ struct sync_connection_base_impl {
template <class Socket>
void send_request_impl(Socket& socket_, string_type const& method,
boost::asio::streambuf& request_buffer) {
(void)method;

write(socket_, request_buffer);
}

template <class Socket>
void read_body_normal(Socket& socket_, basic_response<Tag>& response_,
boost::asio::streambuf& response_buffer,
typename ostringstream<Tag>::type& body_stream) {
(void)response_;

boost::system::error_code error;
if (response_buffer.size() > 0) body_stream << &response_buffer;

Expand Down
8 changes: 7 additions & 1 deletion boost/network/protocol/http/policies/pooled_connection.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ struct pooled_connection_policy : resolver_policy<Tag>::type {
certificate_filename_(certificate_filename),
verify_path_(verify_path),
certificate_file_(certificate_file),
private_key_file_(private_key_file) {}
private_key_file_(private_key_file) {

(void)host;
(void)port;
}

basic_response<Tag> send_request(string_type const& method,
basic_request<Tag> request_, bool get_body,
Expand All @@ -79,6 +83,8 @@ struct pooled_connection_policy : resolver_policy<Tag>::type {
string_type const& method, basic_request<Tag> request_, bool get_body,
body_callback_function_type callback,
body_generator_function_type generator) {
(void)callback;

boost::uint8_t count = 0;
bool retry = false;
do {
Expand Down
6 changes: 6 additions & 0 deletions boost/network/protocol/http/policies/simple_connection.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ struct simple_connection_policy : resolver_policy<Tag>::type {
optional<string_type> const& certificate_file = optional<string_type>(),
optional<string_type> const& private_key_file = optional<string_type>())
: pimpl(), follow_redirect_(follow_redirect) {

(void)hostname;
(void)port;

pimpl.reset(impl::sync_connection_base<
Tag, version_major,
version_minor>::new_connection(resolver, resolve, https,
Expand All @@ -62,6 +66,8 @@ struct simple_connection_policy : resolver_policy<Tag>::type {
basic_request<Tag> request_, bool get_body,
body_callback_function_type callback,
body_generator_function_type generator) {
(void)callback;

basic_response<Tag> response_;
do {
pimpl->init_socket(request_.host(),
Expand Down