-
Notifications
You must be signed in to change notification settings - Fork 424
Verify hostname according to rfc2818 #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
a59ed53
ec4b883
2514f4b
918ea9a
82651b6
ceed0b5
b1f305b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,8 @@ boost::network::http::impl::normal_delegate::normal_delegate( | |
: service_(service) {} | ||
|
||
void boost::network::http::impl::normal_delegate::connect( | ||
asio::ip::tcp::endpoint &endpoint, | ||
asio::ip::tcp::endpoint & endpoint, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please not add a space between the ampersand (&) and the variable? Please keep the code consistent in style. |
||
std::string host, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like you're adding too many spaces here (or a tab character). Please align it properly with the above parameter. |
||
function<void(system::error_code const &)> handler) { | ||
socket_.reset(new asio::ip::tcp::socket(service_)); | ||
socket_->async_connect(endpoint, handler); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to change the declaration of
connection_delegate::connect(...)
to match this -- it's pure virtual there, and it causes the error.