Skip to content

fix chunked client async_normal.hpp #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2013
Merged

fix chunked client async_normal.hpp #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update async_normal.hpp 
If response has
...<chunk>CLRF<hex>CLRF<data>...
We need to skip past chunk-data ending CLRF, otherwise we find it again and on next iteration begin==iter
  • Loading branch information
@frejsoya
frejsoya committed Jun 6, 2013
commit c56cadd582338f89ee025d5c27acedd352ea88a5
2 changes: 1 addition & 1 deletion boost/network/protocol/http/client/connection/async_normal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ namespace boost { namespace network { namespace http { namespace impl {
break;
if (len <= body_string.end() - iter) {
body.insert(body.end(), iter, iter + len);
std::advance(iter, len);
std::advance(iter, len+2);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to do so if iter + len + 1 > body_string.end()? Haven't tested it, but probably instead of patching iterator here, line 450 should be:

std::advance(iter, distance(crlf.begin(), crlf.end()));

}
begin = iter;
}
Expand Down