Skip to content

Commit a370594

Browse files
deanberrisdeanberris
committed
Run clang-tidy with all checks.
These changes haven't been tested; just a raw starting point for fixing things up later on. Generated with: clang-tidy -checks='*' -fix-errors ../libs/network/test/*.cpp -header-filter='boost/network/*' From within a build directory, like this: (while in cpp-netlib) mkdir build cmake -G Ninja -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DOPENSSL_ROOT_DIR=/Users/dberris/homebrew/Cellar/openssl/1.0.2d_1 -DBOOST_ROOT=/Users/dberris/Source/boost_1_56_0 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON ..
1 parent 9bcbde7 commit a370594

File tree

143 files changed

+773
-642
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

143 files changed

+773
-642
lines changed

‎boost/network/constants.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
// (See accompanying file LICENSE_1_0.txt or copy at
77
// http://www.boost.org/LICENSE_1_0.txt)
88

9+
#include <boost/mpl/if.hpp>
910
#include <boost/network/support/is_default_string.hpp>
1011
#include <boost/network/support/is_default_wstring.hpp>
11-
#include <boost/mpl/if.hpp>
1212

1313
namespace boost {
1414
namespace network {
@@ -124,7 +124,7 @@ struct constants_wide {
124124
return https_;
125125
}
126126
};
127-
}
127+
} // namespace impl
128128

129129
template <class Tag>
130130
struct constants

‎boost/network/detail/debug.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include <iostream>
1616
#ifndef BOOST_NETWORK_MESSAGE
1717
#define BOOST_NETWORK_MESSAGE(msg) \
18-
std::cerr << "[DEBUG " << __FILE__ << ':' << __LINE__ << "]: " << msg \
18+
std::cerr << "[DEBUG " << __FILE__ << ':' << __LINE__ << "]: " << (msg) \
1919
<< std::endl;
2020
#endif
2121
#else

‎boost/network/detail/directive_base.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ struct directive_base {
2020
// explicit directive_base(basic_message<tag> & message_)
2121
// : _message(message_)
2222
protected:
23-
~directive_base() {}; // can only be extended
23+
~directive_base() = default;default;; // can only be extended
2424

2525
// mutable basic_message<tag> & _message;
2626
};

‎boost/network/detail/wrapper_base.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ struct wrapper_base {
1717
explicit wrapper_base(Message& message_) : _message(message_) {};
1818

1919
protected:
20-
~wrapper_base() {}; // for extending only
20+
~wrapper_base() = default;default;; // for extending only
2121

2222
Message& _message;
2323
};
@@ -27,7 +27,7 @@ struct wrapper_base_const {
2727
explicit wrapper_base_const(Message const& message_) : _message(message_) {}
2828

2929
protected:
30-
~wrapper_base_const() {}; // for extending only
30+
~wrapper_base_const() = default;default;; // for extending only
3131

3232
Message const& _message;
3333
};

‎boost/network/message.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88

99
#include <boost/network/message_fwd.hpp>
1010
#include <boost/network/traits/string.hpp>
11-
#include <boost/network/traits/ostringstream.hpp>
12-
#include <boost/network/traits/headers_container.hpp>
11+
#include <boost/utility/enable_if.hpp>boost/network/traits/headers_container.hpp>
1312
#include <boost/network/detail/directive_base.hpp>
1413
#include <boost/network/detail/wrapper_base.hpp>
1514
#include <boost/network/message/directives.hpp>

‎boost/network/message/directives/detail/string_directive.hpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@
88

99
#include <boost/network/traits/string.hpp>
1010
#include <boost/variant/variant.hpp>
11-
#include <boost/variant/apply_visitor.hpp>
12-
#include <boost/variant/static_visitor.hpp>
13-
#include <boost/network/support/is_pod.hpp>
14-
#include <boost/utility/enable_if.hpp>
15-
#include <boost/mpl/if.hpp>
16-
#include <boost/mpl/or.hpp>
11+
#include <boost/network/support/is_pod.hpp>>
12+
#include <boost/variant/apply_visitor.hpp>#include <boost/variant/static_visitor.hpp>
13+
#include <boost/mpl/if.hpp<boost/mpl/or.hpp>
14+
#include <boost/utility/enable_if.hpp>ble_if.hpp>
1715

1816
/**
1917
*
@@ -34,7 +32,7 @@
3432
#define BOOST_NETWORK_STRING_DIRECTIVE(name, value, body, pod_body) \
3533
template <class ValueType> \
3634
struct name##_directive { \
37-
ValueType const& value; \
35+
ValueType const& ((value)); \
3836
explicit name##_directive(ValueType const& value_) : value(value_) {} \
3937
name##_directive(name##_directive const& other) : value(other.value) {} \
4038
template <class Tag, template <class> class Message> \

‎boost/network/message/directives/header.hpp

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,13 @@
77
#ifndef __NETWORK_MESSAGE_DIRECTIVES_HEADER_HPP__
88
#define __NETWORK_MESSAGE_DIRECTIVES_HEADER_HPP__
99

10-
#include <boost/network/traits/string.hpp>
11-
#include <boost/network/support/is_async.hpp>
12-
#include <boost/network/support/is_sync.hpp>
13-
#include <boost/thread/future.hpp>
10+
#include <boost/network/support/is_async.hpp>pp>
11+
#include <boost/network/traits/string.hpp>nclude <boost/utility/enable_if.hpp>ude <boost/thread/future.hpp>
1412
#include <boost/mpl/if.hpp>
1513
#include <boost/mpl/or.hpp>
16-
#include <boost/variant/variant.hpp>
17-
#include <boost/variant/apply_visitor.hpp>
18-
#include <boost/variant/static_visitor.hpp>
19-
20-
namespace boost {
14+
#include <boost/variant/apply_visitor.hpp>r.hpp>
15+
#include <boost/variant/static_visitor.hpp>>
16+
#include <boost/variant/variant.hpp>pace boost {
2117
namespace network {
2218

2319
namespace impl {

‎boost/network/message/directives/remove_header.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ struct remove_header_directive {
3434
} // namespace impl
3535

3636
inline impl::remove_header_directive<std::string> remove_header(
37-
std::string header_name) {
37+
std::string /*header_name*/ame*/) {
3838
return impl::remove_header_directive<std::string>(header_name);
3939
}
4040

‎boost/network/message/message_concept.hpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@
1414
#include <boost/network/message/traits/source.hpp>
1515
#include <boost/network/message/traits/destination.hpp>
1616
#include <boost/network/message/traits/headers.hpp>
17-
#include <boost/network/message/wrappers.hpp>
18-
#include <boost/network/message/transformers.hpp>
19-
#include <boost/network/message/directives.hpp>
20-
21-
namespace boost {
17+
#include <boost/network/tags.hp<boost/network/traits/string.hpp>de <boost/thread/future.hpp>oost {
2218
namespace network {
2319

2420
template <class M>

‎boost/network/message/modifiers/add_header.hpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@
77
// (See accompanying file LICENSE_1_0.txt or copy at
88
// http://www.boost.org/LICENSE_1_0.txt)
99

10-
#include <boost/network/support/is_async.hpp>
11-
#include <boost/network/support/is_pod.hpp>
12-
#include <boost/utility/enable_if.hpp>
13-
#include <boost/mpl/and.hpp>
14-
#include <boost/mpl/not.hpp>
10+
#include <boost/mpl/a<boost/mpl/not<boost/network/support/is_async.hpp>nc.hpp>
11+
#include <boost/network/support/is_pod.hpp>ort/is_pod.hpp>
12+
#include <boost/utility/enable_if.hpp>le_if.hpp>
1513

1614
namespace boost {
1715
namespace network {
@@ -38,7 +36,7 @@ inline typename enable_if<is_pod<Tag>, void>::type add_header(
3836
typename Message::header_type header = {key, value};
3937
message.headers.insert(message.headers.end(), header);
4038
}
41-
}
39+
} // namespace impl // namespace impl
4240

4341
template <class Tag, template <class> class Message, class KeyType,
4442
class ValueType>

0 commit comments

Comments
 (0)