Fix #499 - Parsing empty query parameters

leecoder · leecoder · commit 63438e9f68f6 · 2015-04-14T14:59:47.000+09:00
diff --git a/boost/network/uri/accessors.hpp b/boost/network/uri/accessors.hpp
@@ -27,7 +27,7 @@ struct key_value_sequence : spirit::qi::grammar<uri::const_iterator, Map()> {
     pair = key >> -('=' >> value);
     key =
         spirit::qi::char_("a-zA-Z_") >> *spirit::qi::char_("-+.~a-zA-Z_0-9/%");
-    value = +spirit::qi::char_("-+.~a-zA-Z_0-9/%");
+    value = *spirit::qi::char_("-+.~a-zA-Z_0-9/%");
   }
 
   spirit::qi::rule<uri::const_iterator, Map()> query;
diff --git a/libs/network/test/uri/uri_test.cpp b/libs/network/test/uri/uri_test.cpp
@@ -566,3 +566,16 @@ BOOST_AUTO_TEST_CASE(issue_447_test) {
   uri::uri instance("http://[www.foo.com/");
   BOOST_REQUIRE(!uri::valid(instance));
 }
+
+BOOST_AUTO_TEST_CASE(issue_499_test) {
+  uri::uri instance(
+      "http://www.example.com/path?param1&param2=&param3=value");
+  BOOST_REQUIRE(uri::valid(instance));
+
+  std::map<std::string, std::string> queries;
+  uri::query_map(instance, queries);
+  BOOST_REQUIRE_EQUAL(queries.size(), std::size_t(3));
+  BOOST_CHECK_EQUAL(queries["param1"], "");
+  BOOST_CHECK_EQUAL(queries["param2"], "");
+  BOOST_CHECK_EQUAL(queries["param3"], "value");
+}

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ struct key_value_sequence : spirit::qi::grammar<uri::const_iterator, Map()> {`
`27`	`27`	`pair = key >> -('=' >> value);`
`28`	`28`	`key =`
`29`	`29`	`spirit::qi::char_("a-zA-Z_") >> *spirit::qi::char_("-+.~a-zA-Z_0-9/%");`
`30`		`- value = +spirit::qi::char_("-+.~a-zA-Z_0-9/%");`
	`30`	`+ value = *spirit::qi::char_("-+.~a-zA-Z_0-9/%");`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`spirit::qi::rule<uri::const_iterator, Map()> query;`