Added a unit tests for the HTTP client request.

glynos · glynos · commit 4c9fbda9e3ab · 2016-04-10T13:16:44.000+02:00
diff --git a/boost/network/protocol/http/impl/request.hpp b/boost/network/protocol/http/impl/request.hpp
@@ -50,7 +50,7 @@ namespace http {
  */
 template <class Tag>
 struct basic_request : public basic_message<Tag> {
-  mutable boost::network::uri::uri uri_;
+  boost::network::uri::uri uri_;
   std::uint16_t source_port_;
   typedef basic_message<Tag> base_type;
 
@@ -65,10 +65,6 @@ struct basic_request : public basic_message<Tag> {
   explicit basic_request(boost::network::uri::uri const& uri_)
       : uri_(uri_), source_port_(0) {}
 
-  void uri(string_type const& new_uri) { uri_ = new_uri; }
-
-  void uri(boost::network::uri::uri const& new_uri) { uri_ = new_uri; }
-
   basic_request() : base_type(), source_port_(0) {}
 
   basic_request(basic_request const& other)
diff --git a/libs/network/test/http/CMakeLists.txt b/libs/network/test/http/CMakeLists.txt
@@ -12,6 +12,8 @@ if (OPENSSL_FOUND)
 endif()
 
 if (Boost_FOUND)
+    add_subdirectory(client)
+
     set(TESTS response_incremental_parser_test request_incremental_parser_test
       request_linearize_test)
     foreach ( test ${TESTS} )
diff --git a/libs/network/test/http/client/CMakeLists.txt b/libs/network/test/http/client/CMakeLists.txt
@@ -0,0 +1,28 @@
+# Copyright 2016 Glyn Matthews.
+# Distributed under the Boost Software License, Version 1.0.
+# (See accompanying file LICENSE_1_0.txt or copy at
+# http://www.boost.org/LICENSE_1_0.txt)
+
+
+set(
+  TESTS
+  request_test
+  )
+
+foreach(test ${TESTS})
+  set(test_name cpp-netlib-http-client-${test})
+
+  add_executable(${test_name} ${test}.cpp)
+  add_dependencies(${test_name} cppnetlib-uri gtest_main)
+  target_link_libraries(${test_name}
+    ${CMAKE_THREAD_LIBS_INIT} cppnetlib-uri gtest_main)
+  set_target_properties(${test_name}
+    PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CPP-NETLIB_BINARY_DIR}/tests)
+  add_test(${test_name}
+    ${CPP-NETLIB_BINARY_DIR}/tests/${test_name})
+
+  if (OPENSSL_FOUND)
+    target_link_libraries(${test_name} ${OPENSSL_LIBRARIES})
+  endif()
+
+endforeach(test)
diff --git a/libs/network/test/http/client/request_test.cpp b/libs/network/test/http/client/request_test.cpp
@@ -0,0 +1,21 @@
+// Copyright 2016 Glyn Matthews.
+// Distributed under the Boost Software License, Version 1.0.
+// (See accompanying file LICENSE_1_0.txt or copy at
+// http://www.boost.org/LICENSE_1_0.txt)
+
+
+#include <gtest/gtest.h>
+// #include <boost/network/protocol/http/client/request.hpp>
+#include <boost/network/protocol/http/client.hpp>
+
+
+using client_request = boost::network::http::client::request;
+
+
+TEST(http_client_request, construct_from_uri) {
+  ASSERT_NO_THROW(client_request("http://cpp-netlib.org/"));
+}
+
+TEST(http_client_request, construct_from_invalid_uri) {
+  ASSERT_THROW(client_request("I am not a valid URI"), std::exception);
+}
