Move streaming to a log_record method because to remove use of non-standard rvalue binding to a non-const lvalue reference.

imaginaryboy · imaginaryboy · commit 11f3c52503e2 · 2012-11-18T19:01:11.000-05:00
diff --git a/include/network/logging/logging.hpp b/include/network/logging/logging.hpp
@@ -63,12 +63,19 @@ class log_record
     m_text_stream << something;
     return *this;
   }
+  
+  template< typename TypeOfSomething >
+  inline log_record& operator<<( TypeOfSomething&& something )
+  {
+    return write( std::forward<TypeOfSomething>(something) );
+  }
 
   std::string message() const { return m_text_stream.str(); }
   const std::string& filename() const { return m_filename; }
   unsigned long line() const { return m_line; }
 
 private:
+
   // disable copy
   log_record( const log_record& ); // = delete;
   log_record& operator=( const log_record& ); // = delete;
@@ -77,12 +84,6 @@ class log_record
   std::string m_filename; // = UNKNOWN_FILE_NAME;
   unsigned long m_line; // = 0;
 };
-  
-template< typename TypeOfSomething >
-inline log_record& operator<<( log_record& log, TypeOfSomething&& something )
-{
-  return log.write( std::forward<TypeOfSomething>(something) );
-}
 
 }}
 
