Bug #17218692 Correct snprintf buffer size (no need for -1, because snprintf puts allways a \0 at string end)

silvakid · silvakid · commit 025f4339f0fd · 2015-05-12T11:49:20.000+01:00
Add unit test with this bug case.
diff --git a/driver/mysql_ps_resultset.cpp b/driver/mysql_ps_resultset.cpp
@@ -980,9 +980,9 @@ MySQL_Prepared_ResultSet::getString(const uint32_t columnIndex) const
 			char buf[18];
 			MYSQL_TIME * t = static_cast<MYSQL_TIME *>(result_bind->rbind[columnIndex - 1].buffer);
                         if (t->second_part) {
-			        snprintf(buf, sizeof(buf) - 1, "%s%02d:%02d:%02d.%06lu", t->neg? "-":"", t->hour, t->minute, t->second, t->second_part);
+                          snprintf(buf, sizeof(buf), "%s%02d:%02d:%02d.%06lu", t->neg? "-":"", t->hour, t->minute, t->second, t->second_part);
                         } else {
-			        snprintf(buf, sizeof(buf) - 1, "%s%02d:%02d:%02d", t->neg? "-":"", t->hour, t->minute, t->second);
+                          snprintf(buf, sizeof(buf), "%s%02d:%02d:%02d", t->neg? "-":"", t->hour, t->minute, t->second);
                         }
 			CPP_INFO_FMT("It's a time %s", buf);
 			return sql::SQLString(buf);
diff --git a/test/unit/bugs/bugs.cpp b/test/unit/bugs/bugs.cpp
@@ -733,5 +733,41 @@ void bugs::bug66235()
 }
 
 
+void bugs::bug17218692()
+{
+  logMsg("bugs::bug17218692");
+  try
+  {
+
+    stmt->execute("DROP TABLE IF EXISTS bug17218692");
+    stmt->execute("CREATE TABLE bug17218692(c1  time(6))");
+    stmt->execute("INSERT INTO bug17218692 VALUES('-838:59:58.987657')");
+
+    res.reset(stmt->executeQuery("select * from bug17218692"));
+    res->next();
+
+    std::stringstream log;
+    log<<"["<<res->getString(1)<<"]";
+
+    ASSERT_EQUALS(log.str(), "[-838:59:58.987657]");
+
+    pstmt.reset(con->prepareStatement("select * from bug17218692 "));
+    res.reset(pstmt->executeQuery());
+    res->next();
+
+    std::stringstream log2;
+    log2 << "["<<res->getString(1)<<"]";
+    ASSERT_EQUALS(log.str(), log2.str());
+
+  }
+  catch (sql::SQLException & e)
+  {
+    FAIL("Exception thrown");
+    throw;
+  }
+
+
+}
+
 } /* namespace regression */
 } /* namespace testsuite */
diff --git a/test/unit/bugs/bugs.h b/test/unit/bugs/bugs.h
@@ -61,6 +61,7 @@ class bugs : public unit_fixture
     TEST_CASE(bug19938873_stmt);
     TEST_CASE(bug68523);
     TEST_CASE(bug66235);
+    TEST_CASE(bug17218692);
   }
 
   /**
@@ -103,6 +104,8 @@ class bugs : public unit_fixture
   void bug68523();
 
   void bug66235();
+
+  void bug17218692();
 };
 
 REGISTER_FIXTURE(bugs);
