rename 'Preview' to 'Placeholder'

Benjamin Kniffler · Benjamin Kniffler · commit 71a98ac40fcf · 2016-04-04T17:25:29.000+02:00
diff --git a/docs/client/components/pages/Dnd/SimpleDndEditor/index.js b/docs/client/components/pages/Dnd/SimpleDndEditor/index.js
@@ -15,7 +15,7 @@ const dndPlugin = createDndPlugin({
   allowDrop: true,
   handleUpload: (data, success, failed, progress) =>
     mockUpload(data, success, failed, progress),
-  handlePreview: (state, selection, data) => {
+  handlePlaceholder: (state, selection, data) => {
     const { type } = data;
     if (type.indexOf('image/') === 0) {
       return addBlock(state, state.getSelection(), 'block-image', data);
diff --git a/docs/client/components/pages/Dnd/components/block-text.js b/docs/client/components/pages/Dnd/components/block-text.js
@@ -18,5 +18,5 @@ class BlockText extends Component {
 }
 
 export default Draggable(BlockText, {
-  useDiv: true
+  useDiv: true,
 });
diff --git a/docs/client/components/pages/Dnd/components/placeholder-github.js b/docs/client/components/pages/Dnd/components/placeholder-github.js
@@ -1,6 +1,6 @@
 import React, { Component } from 'react';
 
-class PreviewGithub extends Component {
+class PlaceholderGithub extends Component {
   render() {
     const { blockProps, block } = this.props;
 
@@ -12,4 +12,4 @@ class PreviewGithub extends Component {
   }
 }
 
-export default PreviewGithub;
+export default PlaceholderGithub;
diff --git a/draft-js-dnd-plugin/src/modifiers/onDropFile.js b/draft-js-dnd-plugin/src/modifiers/onDropFile.js
@@ -4,7 +4,7 @@ import modifyBlockData from './modifyBlockData';
 import { readFiles } from '../utils/file';
 import { getBlocksWhereEntityData } from '../utils/block';
 
-function defaultHandlePreview(state, selection, data, defaultBlockType) {
+function defaultHandlePlaceholder(state, selection, data, defaultBlockType) {
   return addBlock(state, state.getSelection(), defaultBlockType, data);
 }
 
@@ -15,7 +15,7 @@ function defaultHandleBlock(state, selection, data, defaultBlockType) {
 export default function onDropFile(config) {
   return function onDropFileInner(selection, files, { getEditorState, setEditorState }) {
     // Get upload function from config or editor props
-    const { handleUpload, handlePreview, handleBlock, defaultBlockType, handleProgress } = config;
+    const { handleUpload, handlePlaceholder, handleBlock, defaultBlockType, handleProgress } = config;
     if (handleUpload) {
       const formData = new FormData();
 
@@ -31,13 +31,13 @@ export default function onDropFile(config) {
       data.formData = data;
 
       // Read files on client side
-      readFiles(data.files).then(previews => {
+      readFiles(data.files).then(placeholders => {
         // Add blocks for each image before uploading
         let state = getEditorState();
-        previews.forEach(preview => {
-          state = handlePreview
-            ? handlePreview(state, selection, { ...preview, progress: 1 })
-            : defaultHandlePreview(state, selection, { ...preview, progress: 1 }, defaultBlockType);
+        placeholders.forEach(placeholder => {
+          state = handlePlaceholder
+            ? handlePlaceholder(state, selection, { ...placeholder, progress: 1 })
+            : defaultHandlePlaceholder(state, selection, { ...placeholder, progress: 1 }, defaultBlockType);
         });
         setEditorState(state);
 
@@ -64,8 +64,8 @@ export default function onDropFile(config) {
         }, (percent) => {
           // On progress, set entity data's progress field
           let newEditorState = getEditorState();
-          previews.forEach(preview => {
-            const blocks = getBlocksWhereEntityData(newEditorState, preview2 => preview2.src === preview.src && preview2.progress !== undefined);
+          placeholders.forEach(placeholder => {
+            const blocks = getBlocksWhereEntityData(newEditorState, p => p.src === placeholder.src && p.progress !== undefined);
             if (blocks.size) {
               newEditorState = modifyBlockData(newEditorState, blocks.first().get('key'), { progress: percent });
             }

Original file line number	Diff line number	Diff line change
`@@ -18,5 +18,5 @@ class BlockText extends Component {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`export default Draggable(BlockText, {`
`21`		`- useDiv: true`
	`21`	`+ useDiv: true,`
`22`	`22`	`});`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import React, { Component } from 'react';`
`2`	`2`
`3`		`-class PreviewGithub extends Component {`
	`3`	`+class PlaceholderGithub extends Component {`
`4`	`4`	`render() {`
`5`	`5`	`const { blockProps, block } = this.props;`
`6`	`6`
`@@ -12,4 +12,4 @@ class PreviewGithub extends Component {`
`12`	`12`	`}`
`13`	`13`	`}`
`14`	`14`
`15`		`-export default PreviewGithub;`
	`15`	`+export default PlaceholderGithub;`