-
Notifications
You must be signed in to change notification settings - Fork 3
Preview/dot env #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Preview/dot env #67
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
reviews: | ||
path_filters: ["**/.env",".env"] |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,5 @@ | ||||||||
PORT=3000 | ||||||||
PORT=8000 | ||||||||
DB_URL postgres://localhost | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Malformed line – missing -DB_URL postgres://localhost
+DB_URL=postgres://localhost 📝 Committable suggestion
Suggested change
🧰 Tools🪛 dotenv-linter (3.3.0)[warning] 3-3: [IncorrectDelimiter] The DB_URL postgres://localhost key has incorrect delimiter [warning] 3-3: [KeyWithoutValue] The DB_URL postgres://localhost key should be with a value or have an equal sign [warning] 3-3: [LowercaseKey] The DB_URL postgres://localhost key should be in uppercase [warning] 3-3: [UnorderedKey] The DB_URL postgres://localhost key should go before the PORT key 🤖 Prompt for AI Agents
|
||||||||
SECRET_KEY=12345 | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Avoid committing real secrets to VCS 🧰 Tools🪛 dotenv-linter (3.3.0)[warning] 4-4: [LeadingCharacter] Invalid leading character detected 🤖 Prompt for AI Agents
Leading whitespace breaks variable name - SECRET_KEY=12345
+SECRET_KEY=12345 📝 Committable suggestion
Suggested change
🧰 Tools🪛 dotenv-linter (3.3.0)[warning] 4-4: [LeadingCharacter] Invalid leading character detected 🤖 Prompt for AI Agents
|
||||||||
UNQUOTED VALUE | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Invalid syntax – not a -UNQUOTED VALUE
+UNQUOTED_VALUE="Some value with spaces" 📝 Committable suggestion
Suggested change
🧰 Tools🪛 dotenv-linter (3.3.0)[warning] 5-5: [IncorrectDelimiter] The UNQUOTED VALUE key has incorrect delimiter [warning] 5-5: [KeyWithoutValue] The UNQUOTED VALUE key should be with a value or have an equal sign 🤖 Prompt for AI Agents
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate
PORT
declaration – choose one and document the intentTwo different values (
3000
and8000
) are defined for the same variable. Most dotenv loaders resolve to the last occurrence (8000
), silently shadowing the first value and confusing anyone skimming the file. Keep a single entry or differentiate (e.g.,PORT_DEV
/PORT_PROD
) and comment which one is expected.📝 Committable suggestion
🧰 Tools
🪛 dotenv-linter (3.3.0)
[warning] 2-2: [DuplicatedKey] The PORT key is duplicated
🤖 Prompt for AI Agents