-
Notifications
You must be signed in to change notification settings - Fork 3
Circle CI files #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Circle CI files #21
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,21 @@ | ||||||||||||||
version: 2.1 | ||||||||||||||
|
||||||||||||||
jobs: | ||||||||||||||
build: | ||||||||||||||
docker: | ||||||||||||||
- image: circleci/node:14 | ||||||||||||||
steps: | ||||||||||||||
- checkout | ||||||||||||||
- run: | ||||||||||||||
name: Install dependencies | ||||||||||||||
command: npm install | ||||||||||||||
- run | ||||||||||||||
name: Run tests | ||||||||||||||
command: npm test | ||||||||||||||
Comment on lines
+12
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Syntax error – missing colon after
- - run
- name: Run tests
- command: npm test
+ - run:
+ name: Run tests
+ command: npm test Without this, the config will not load and the workflow will never start. 📝 Committable suggestion
Suggested change
🧰 Tools🪛 CircleCI (0.1.32638)13-13: Unable to parse YAML (mapping values are not allowed here : name:) 🪛 YAMLlint (1.37.1)[error] 13-13: syntax error: mapping values are not allowed here (syntax) 🤖 Prompt for AI Agents
|
||||||||||||||
|
||||||||||||||
workflows: | ||||||||||||||
version: 2 | ||||||||||||||
build_and_test: | ||||||||||||||
jobs: | ||||||||||||||
- build | ||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
reviews: | ||
path_filters: ["**/*.yml","**/*.yaml"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Node 14 image is end-of-life – upgrade to a maintained LTS.
CircleCI now offers
cimg/node:18.20
andcimg/node:20.12
(or later). Staying on Node 14 leaves you without security patches and newer npm features.🤖 Prompt for AI Agents