Check for passive effects on the root fiber (facebook#19488)

acdlite · Brian Vaughn · web-flow · commit 6ef997b534bf · 2020-07-30T09:17:22.000-04:00
The root fiber doesn't have a parent from which we can read the
`subtreeTag`, so we need to check its `effectTag` directly.

The root fiber previously did not have any pending passive effects,
but it does now that deleted fibers are cleaned up in the passive phase.

This allows us to remove a `schedulePassiveEffectCallback` call from the
synchronous unmount path.

Co-authored-by: Brian Vaughn &lt;bvaughn@fb.com&gt;
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -879,8 +879,6 @@ function commitUnmount(
               if ((tag & HookPassive) !== NoHookEffect) {
                 // TODO: Consider if we can move this block out of the synchronous commit phase
                 effect.tag |= HookHasEffect;
-
-                schedulePassiveEffectCallback();
               } else {
                 if (
                   enableProfilerTimer &&
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js
@@ -2183,7 +2183,10 @@ function commitRootImpl(root, renderPriorityLevel) {
     }
 
     // If there are pending passive effects, schedule a callback to process them.
-    if ((finishedWork.subtreeTag & PassiveSubtreeTag) !== NoSubtreeTag) {
+    if (
+      (finishedWork.subtreeTag & PassiveSubtreeTag) !== NoSubtreeTag ||
+      (finishedWork.effectTag & PassiveMask) !== NoEffect
+    ) {
       if (!rootDoesHavePassiveEffects) {
         rootDoesHavePassiveEffects = true;
         scheduleCallback(NormalSchedulerPriority, () => {
