Skip to content

Commit ec2fe4b

Browse files
committed
Add range slider label
Added label to sliders on Editor -> IDE preferences (Word wrap limit, Tab size). Closes andrewbrg#14.
1 parent 8150276 commit ec2fe4b

File tree

4 files changed

+46
-7
lines changed

4 files changed

+46
-7
lines changed

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "1.0.96",
2+
"version": "1.1.0",
33
"manifest_version": 2,
44
"minimum_chrome_version": "51",
55
"name": "Code Pad Text Editor",

src/css/main.css

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,3 +606,18 @@ input.cmn-tgl-rnd-flt:checked + label:after {
606606
.bootstrapMenu .dropdown-item .fa {
607607
font-size: 0.9rem;
608608
}
609+
610+
/*******************************************************************************/
611+
/******************************** Range Slider Fix *****************************/
612+
/*******************************************************************************/
613+
.range-slider {
614+
white-space: nowrap;
615+
}
616+
617+
.range-slider > * {
618+
display: inline-block;
619+
}
620+
621+
.range-slider-range {
622+
width: 95.5%;
623+
}

src/html/modals/editor/ide.settings.html

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,18 +178,22 @@
178178
<div class="form-group">
179179
<label>
180180
<strong>Tab size</strong><br/>
181-
<span>#No. of columns per tab</span>
181+
<span>Number of columns per tab</span>
182182
</label>
183183
<div class="range-slider">
184-
<input data-toggle="tooltip"
184+
<input id="tabSize"
185+
data-toggle="tooltip"
185186
data-action="ide-setting"
186187
data-option="tabSize"
187188
class="range-slider-range"
188189
type="range"
189190
min="1"
190191
max="8"
191192
step="1"
192-
title="Tab size"/>
193+
title="Tab size"/>
194+
195+
<label for="tabSize"
196+
title="Default: 4, Current: 4">4</label>
193197
</div>
194198
</div>
195199
</div>
@@ -198,10 +202,11 @@
198202
<div class="form-group">
199203
<label>
200204
<strong>Word wrap limit</strong><br/>
201-
<span>#No. of characters per line before wrapping</span>
205+
<span>Number of characters per line before wrapping</span>
202206
</label>
203207
<div class="range-slider">
204-
<input data-toggle="tooltip"
208+
<input id="wrap"
209+
data-toggle="tooltip"
205210
data-action="ide-setting"
206211
data-option="wrap"
207212
class="range-slider-range"
@@ -210,6 +215,9 @@
210215
max="128"
211216
step="1"
212217
title="Word wrap limit"/>
218+
219+
<label for="wrap"
220+
title="Default: 68, Current: 68">68</label>
213221
</div>
214222
</div>
215223
</div>

src/js/events.js

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,25 @@ $(document).ready(function () {
100100
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////
101101

102102
$(document).on('input change', '[data-action="ide-setting"]', function () {
103-
IdeSettings.persistAndApply(IdeSettings.getKeyValFromEl($(this)));
103+
let $this = $(this);
104+
let $next = $(this).next();
105+
106+
IdeSettings.persistAndApply(IdeSettings.getKeyValFromEl($this));
107+
108+
if ($this.hasClass('range-slider-range')) {
109+
$next.text($this.val());
110+
111+
let title = $next.attr('title').split(', ');
112+
title[1] = 'Current: ' + $this.val();
113+
$next.attr('title', title.join(', '));
114+
}
104115
});
105116

117+
/*$(document).on('input', '', function () {
118+
var $this = $(this);
119+
$this.next().val($this.val());
120+
});*/
121+
106122
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////
107123

108124

0 commit comments

Comments
 (0)