1.0.90

andrewbrg · andrewbrg · commit df064bd5b666 · 2017-12-23T15:01:05.000+01:00
diff --git a/manifest.json b/manifest.json
@@ -1,5 +1,5 @@
 {
-  "version": "1.0.89",
+  "version": "1.0.90",
   "manifest_version": 2,
   "minimum_chrome_version": "51",
   "name": "Code Pad IDE",
diff --git a/src/js/handlers/editors.js b/src/js/handlers/editors.js
@@ -268,14 +268,15 @@ var EditorsHandler = function () {
 
         idx = parseInt(idx);
         this._getTabMode(idx).then(function (data) {
-            if (JSON.parse(data).mode === that.undefinedFileMode) {
+            data = that.isJsonString(data) ? JSON.parse(data) : data;
+            if (data.mode === that.undefinedFileMode) {
                 chrome.fileSystem.getDisplayPath(fileEntry, function (path) {
                     // noinspection JSUnresolvedVariable
                     that.getEditor(idx).setOption('mode', that.Modelist.getModeForPath(path).mode);
                     that._populateStatusBar(idx);
                 });
             } else {
-                that.getEditor(idx).setOption('mode', 'ace/mode/' + JSON.parse(data).mode);
+                that.getEditor(idx).setOption('mode', 'ace/mode/' + data.mode);
                 that._populateStatusBar(idx);
             }
         });
@@ -390,14 +391,15 @@ var EditorsHandler = function () {
             data    = that.isJsonString(data) ? JSON.parse(data) : data;
             var ext = that._getTabFileExtension(idx);
             if (typeof ext === typeof undefined) {
-                deferred.resolve(JSON.stringify({
+                deferred.resolve({
                     "icon": that.undefinedFileIcon,
                     "mode": that.undefinedFileMode,
                     "name": that.undefinedFileName
-                }));
+                });
             }
-            if (data.hasOwnProperty(ext)) {
-                deferred.resolve(JSON.stringify(data[ext]));
+
+            if (typeof data[ext] !== typeof undefined) {
+                deferred.resolve(data[ext]);
             }
         });
 
@@ -431,6 +433,7 @@ var EditorsHandler = function () {
 
         idx = parseInt(idx);
         this._getTabMode(idx).then(function (data) {
+            data    = that.isJsonString(data) ? JSON.parse(data) : data;
             var $el = that.getTabNavEl(idx).find('*[data-toggle="tab"]').first();
             $el.find('.filetype-icon').remove();
             $el.append(that.navTabIconHtml);
diff --git a/src/js/handlers/notifications.js b/src/js/handlers/notifications.js
@@ -4,7 +4,7 @@ var NotificationsHandler = function () {
     this.ratingReminderId = 'rating_reminder';
 
     this.versionKey     = 'last_notified_version';
-    this.requestRateKey = 'rating_requested';
+    this.requestRateKey = 'rate_requested';
 
     this.init = function () {
 
@@ -64,7 +64,7 @@ var NotificationsHandler = function () {
 
                 }
             });
-        }, 30000);
+        }, 3000);
 
         chrome.notifications.onButtonClicked.addListener(function (notificationId) {
             if (notificationId === that.ratingReminderId) {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "version": "1.0.89",`
	`2`	`+ "version": "1.0.90",`
`3`	`3`	`"manifest_version": 2,`
`4`	`4`	`"minimum_chrome_version": "51",`
`5`	`5`	`"name": "Code Pad IDE",`