Check cli version before adding --reason flag

kacpersaw · kacpersaw · commit 98414b504132 · 2025-07-15T15:03:59.000+02:00
diff --git a/src/api.ts b/src/api.ts
@@ -16,6 +16,7 @@ import { getHeaderArgs } from "./headers";
 import { getProxyForUrl } from "./proxy";
 import { Storage } from "./storage";
 import { expandPath } from "./util";
+import { FeatureSet } from "./featureSet";
 
 export const coderSessionTokenHeader = "Coder-Session-Token";
 
@@ -174,6 +175,7 @@ export async function startWorkspaceIfStoppedOrFailed(
 	binPath: string,
 	workspace: Workspace,
 	writeEmitter: vscode.EventEmitter<string>,
+	featureSet: FeatureSet
 ): Promise<Workspace> {
 	// Before we start a workspace, we make an initial request to check it's not already started
 	const updatedWorkspace = await restClient.getWorkspace(workspace.id);
@@ -189,10 +191,12 @@ export async function startWorkspaceIfStoppedOrFailed(
 			...getHeaderArgs(vscode.workspace.getConfiguration()),
 			"start",
 			"--yes",
-			workspace.owner_name + "/" + workspace.name,
-			"--reason",
-			"vscode_connection",
+			workspace.owner_name + "/" + workspace.name
 		];
+		if (featureSet.buildReason) {
+			startArgs.push(...['--reason', 'vscode_connection'])
+		}
+
 		const startProcess = spawn(binPath, startArgs);
 
 		startProcess.stdout.on("data", (data: Buffer) => {
diff --git a/src/featureSet.ts b/src/featureSet.ts
@@ -4,6 +4,7 @@ export type FeatureSet = {
 	vscodessh: boolean;
 	proxyLogDirectory: boolean;
 	wildcardSSH: boolean;
+	buildReason: boolean;
 };
 
 /**
@@ -29,5 +30,10 @@ export function featureSetForVersion(
 		wildcardSSH:
 			(version ? version.compare("2.19.0") : -1) >= 0 ||
 			version?.prerelease[0] === "devel",
+
+		// --reason flag was added in 2.25.0
+		buildReason:
+			(version?.compare("2.25.0") || 0) >= 0 ||
+			version?.prerelease[0] === "devel",
 	};
 }
diff --git a/src/remote.ts b/src/remote.ts
@@ -68,6 +68,7 @@ export class Remote {
 		workspace: Workspace,
 		label: string,
 		binPath: string,
+		featureSet: FeatureSet
 	): Promise<Workspace | undefined> {
 		const workspaceName = `${workspace.owner_name}/${workspace.name}`;
 
@@ -140,6 +141,7 @@ export class Remote {
 									binPath,
 									workspace,
 									writeEmitter,
+									featureSet
 								);
 								break;
 							case "failed":
@@ -159,6 +161,7 @@ export class Remote {
 										binPath,
 										workspace,
 										writeEmitter,
+										featureSet
 									);
 									break;
 								}
@@ -393,6 +396,7 @@ export class Remote {
 				workspace,
 				parts.label,
 				binaryPath,
+				featureSet
 			);
 			if (!updatedWorkspace) {
 				// User declined to start the workspace.
