test: update validation_test tests

ssncferreira · ssncferreira · commit 484b5b1c8943 · 2025-07-22T12:11:30.000Z
diff --git a/provider/helpers/validation_test.go b/provider/helpers/validation_test.go
@@ -138,17 +138,14 @@ func TestValidateURL(t *testing.T) {
 			warnings, errors := ValidateURL(tt.value, tt.label)
 
 			if tt.expectError {
-				require.NotEmpty(t, errors, "expected an error but got none")
-
-				if tt.errorContains != "" {
-					require.Contains(t, errors[0].Error(), tt.errorContains)
-				}
+				require.Len(t, errors, 1, "expected an error but got none")
+				require.Contains(t, errors[0].Error(), tt.errorContains)
 			} else {
 				require.Empty(t, errors, "expected no errors but got: %v", errors)
 			}
 
 			// Should always return nil for warnings
-			require.Nil(t, warnings, "expected warnings to be nil, got %v", warnings)
+			require.Nil(t, warnings, "expected warnings to be nil but got: %v", warnings)
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -138,17 +138,14 @@ func TestValidateURL(t *testing.T) {`
`138`	`138`	`warnings, errors := ValidateURL(tt.value, tt.label)`
`139`	`139`
`140`	`140`	`if tt.expectError {`
`141`		`- require.NotEmpty(t, errors, "expected an error but got none")`
`142`		`-`
`143`		`- if tt.errorContains != "" {`
`144`		`- require.Contains(t, errors[0].Error(), tt.errorContains)`
`145`		`- }`
	`141`	`+ require.Len(t, errors, 1, "expected an error but got none")`
	`142`	`+ require.Contains(t, errors[0].Error(), tt.errorContains)`
`146`	`143`	`} else {`
`147`	`144`	`require.Empty(t, errors, "expected no errors but got: %v", errors)`
`148`	`145`	`}`
`149`	`146`
`150`	`147`	`// Should always return nil for warnings`
`151`		`- require.Nil(t, warnings, "expected warnings to be nil, got %v", warnings)`
	`148`	`+ require.Nil(t, warnings, "expected warnings to be nil but got: %v", warnings)`
`152`	`149`	`})`
`153`	`150`	`}`
`154`	`151`	`}`