chore: add size limit to preset icon and description

ssncferreira · ssncferreira · commit 23765b081f40 · 2025-07-22T17:05:26.000Z
diff --git a/provider/workspace_preset.go b/provider/workspace_preset.go
@@ -96,18 +96,22 @@ func workspacePresetDataSource() *schema.Resource {
 				ValidateFunc: validation.StringIsNotEmpty,
 			},
 			"description": {
-				Type:        schema.TypeString,
-				Optional:    true,
-				Description: "Describe what this preset does.",
+				Type:         schema.TypeString,
+				Optional:     true,
+				Description:  "Describe what this preset does.",
+				ValidateFunc: validation.StringLenBetween(0, 128),
 			},
 			"icon": {
 				Type: schema.TypeString,
 				Description: "A URL to an icon that will display in the dashboard. View built-in " +
 					"icons [here](https://github.com/coder/coder/tree/main/site/static/icon). Use a " +
 					"built-in icon with `\"${data.coder_workspace.me.access_url}/icon/<path>\"`.",
-				ForceNew:     true,
-				Optional:     true,
-				ValidateFunc: helpers.ValidateURL,
+				ForceNew: true,
+				Optional: true,
+				ValidateFunc: validation.All(
+					helpers.ValidateURL,
+					validation.StringLenBetween(0, 256),
+				),
 			},
 			"default": {
 				Type:        schema.TypeBool,
diff --git a/provider/workspace_preset_test.go b/provider/workspace_preset_test.go
@@ -97,6 +97,20 @@ func TestWorkspacePreset(t *testing.T) {
 			// So we test it here to make sure we don't regress.
 			ExpectError: nil,
 		},
+		{
+			Name: "Description field exceeds maximum supported length (128 characters)",
+			Config: `
+			data "coder_workspace_preset" "preset_1" {
+				name = "preset_1"
+				description = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur vehicula leo sit amet mi laoreet, sed ornare velit tincidunt. Proin gravida lacinia blandit."
+				parameters = {
+					"region" = "us-east1-a"
+				}
+			}`,
+			// This validation is done by Terraform, but it could still break if we misconfigure the schema.
+			// So we test it here to make sure we don't regress.
+			ExpectError: regexp.MustCompile(`expected length of description to be in the range \(0 - 128\)`),
+		},
 		{
 			Name: "Icon field is empty",
 			Config: `
@@ -125,6 +139,20 @@ func TestWorkspacePreset(t *testing.T) {
 			// So we test it here to make sure we don't regress.
 			ExpectError: regexp.MustCompile("invalid URL escape"),
 		},
+		{
+			Name: "Icon field exceeds maximum supported length (256 characters)",
+			Config: `
+			data "coder_workspace_preset" "preset_1" {
+				name = "preset_1"
+				icon = "https://example.com/path/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.svg"
+				parameters = {
+					"region" = "us-east1-a"
+				}
+			}`,
+			// This validation is done by Terraform, but it could still break if we misconfigure the schema.
+			// So we test it here to make sure we don't regress.
+			ExpectError: regexp.MustCompile(`expected length of icon to be in the range \(0 - 256\)`),
+		},
 		{
 			Name: "Parameters field is not provided",
 			Config: `
