Skip to content

flake: data race: TestUpdateWithRichParameters/EphemeralParameterFlags #543

@johnstcn

Description

@johnstcn

Seen here: https://github.com/coder/coder/actions/runs/14089639356/job/39462821472?pr=17116

2025-03-26T17:33:04.6830124Z ==================
2025-03-26T17:33:04.6830374Z WARNING: DATA RACE
2025-03-26T17:33:04.6830629Z Read at 0x00c0092ac0c8 by goroutine 9887:
2025-03-26T17:33:04.6831032Z   github.com/coder/coder/v2/provisioner/echo.TarWithOptions()
2025-03-26T17:33:04.6831549Z       /home/runner/work/coder/coder/provisioner/echo/serve.go:257 +0x1147
2025-03-26T17:33:04.6832016Z   github.com/coder/coder/v2/coderd/coderdtest.CreateTemplateVersion()
2025-03-26T17:33:04.6832594Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:863 +0xee
2025-03-26T17:33:04.6833083Z   github.com/coder/coder/v2/cli_test.TestUpdateWithRichParameters.func1()
2025-03-26T17:33:04.6833605Z       /home/runner/work/coder/coder/cli/update_test.go:118 +0x251
2025-03-26T17:33:04.6834063Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).InTx.func1()
2025-03-26T17:33:04.6834621Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:695 +0x131
2025-03-26T17:33:04.6835121Z   github.com/coder/coder/v2/coderd/database/dbmem.(*FakeQuerier).InTx()
2025-03-26T17:33:04.6835747Z       /home/runner/work/coder/coder/coderd/database/dbmem/dbmem.go:431 +0x365
2025-03-26T17:33:04.6836216Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).InTx()
2025-03-26T17:33:04.6836792Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:692 +0xf9
2025-03-26T17:33:04.6837263Z   github.com/coder/coder/v2/coderd/cryptokeys.(*rotator).rotateKeys()
2025-03-26T17:33:04.6837790Z       /home/runner/work/coder/coder/coderd/cryptokeys/rotate.go:97 +0x195
2025-03-26T17:33:04.6838233Z   github.com/coder/coder/v2/coderd/cryptokeys.StartRotator()
2025-03-26T17:33:04.6838724Z       /home/runner/work/coder/coder/coderd/cryptokeys/rotate.go:72 +0x590
2025-03-26T17:33:04.6839109Z   github.com/coder/coder/v2/coderd.New()
2025-03-26T17:33:04.6839524Z       /home/runner/work/coder/coder/coderd/coderd.go:527 +0x451b
2025-03-26T17:33:04.6839916Z   github.com/coder/coder/v2/coderd/coderdtest.NewWithAPI()
2025-03-26T17:33:04.6840517Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:569 +0xf1
2025-03-26T17:33:04.6840977Z   github.com/coder/coder/v2/coderd/coderdtest.newWithCloser()
2025-03-26T17:33:04.6841538Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:211 +0x3b
2025-03-26T17:33:04.6841943Z   github.com/coder/coder/v2/coderd/coderdtest.New()
2025-03-26T17:33:04.6842417Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:179 +0x27
2025-03-26T17:33:04.6842909Z   github.com/coder/coder/v2/cli_test.TestUpdateWithRichParameters.func1()
2025-03-26T17:33:04.6843428Z       /home/runner/work/coder/coder/cli/update_test.go:115 +0xe8
2025-03-26T17:33:04.6843752Z   testing.tRunner()
2025-03-26T17:33:04.6844190Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1792 +0x225
2025-03-26T17:33:04.6844554Z   testing.(*T).Run.gowrap1()
2025-03-26T17:33:04.6844961Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x44
2025-03-26T17:33:04.6845388Z 
2025-03-26T17:33:04.6845526Z Previous write at 0x00c0092ac0c8 by goroutine 9889:
2025-03-26T17:33:04.6845915Z   github.com/coder/coder/v2/provisioner/echo.TarWithOptions()
2025-03-26T17:33:04.6846421Z       /home/runner/work/coder/coder/provisioner/echo/serve.go:258 +0x11b0
2025-03-26T17:33:04.6846910Z   github.com/coder/coder/v2/coderd/coderdtest.CreateTemplateVersion()
2025-03-26T17:33:04.6847447Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:863 +0xee
2025-03-26T17:33:04.6847945Z   github.com/coder/coder/v2/cli_test.TestUpdateWithRichParameters.func3()
2025-03-26T17:33:04.6848438Z       /home/runner/work/coder/coder/cli/update_test.go:234 +0x28a
2025-03-26T17:33:04.6848869Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).InTx.func1()
2025-03-26T17:33:04.6849470Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:695 +0x131
2025-03-26T17:33:04.6849950Z   github.com/coder/coder/v2/coderd/database/dbmem.(*FakeQuerier).InTx()
2025-03-26T17:33:04.6850495Z       /home/runner/work/coder/coder/coderd/database/dbmem/dbmem.go:431 +0x365
2025-03-26T17:33:04.6850966Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).InTx()
2025-03-26T17:33:04.6851511Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:692 +0xf9
2025-03-26T17:33:04.6852001Z   github.com/coder/coder/v2/coderd/cryptokeys.(*rotator).rotateKeys()
2025-03-26T17:33:04.6852507Z       /home/runner/work/coder/coder/coderd/cryptokeys/rotate.go:97 +0x195
2025-03-26T17:33:04.6852932Z   github.com/coder/coder/v2/coderd/cryptokeys.StartRotator()
2025-03-26T17:33:04.6853455Z       /home/runner/work/coder/coder/coderd/cryptokeys/rotate.go:72 +0x590
2025-03-26T17:33:04.6853830Z   github.com/coder/coder/v2/coderd.New()
2025-03-26T17:33:04.6854246Z       /home/runner/work/coder/coder/coderd/coderd.go:527 +0x451b
2025-03-26T17:33:04.6854654Z   github.com/coder/coder/v2/coderd/coderdtest.NewWithAPI()
2025-03-26T17:33:04.6855273Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:569 +0xf1
2025-03-26T17:33:04.6855734Z   github.com/coder/coder/v2/coderd/coderdtest.newWithCloser()
2025-03-26T17:33:04.6856244Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:211 +0x3b
2025-03-26T17:33:04.6856645Z   github.com/coder/coder/v2/coderd/coderdtest.New()
2025-03-26T17:33:04.6857157Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:179 +0x27
2025-03-26T17:33:04.6857641Z   github.com/coder/coder/v2/cli_test.TestUpdateWithRichParameters.func3()
2025-03-26T17:33:04.6858136Z       /home/runner/work/coder/coder/cli/update_test.go:231 +0xe8
2025-03-26T17:33:04.6858469Z   testing.tRunner()
2025-03-26T17:33:04.6858879Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1792 +0x225
2025-03-26T17:33:04.6859260Z   testing.(*T).Run.gowrap1()
2025-03-26T17:33:04.6859688Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x44
2025-03-26T17:33:04.6859912Z 
2025-03-26T17:33:04.6860032Z Goroutine 9887 (running) created at:
2025-03-26T17:33:04.6860335Z   testing.(*T).Run()
2025-03-26T17:33:04.6860776Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x8f2
2025-03-26T17:33:04.6861305Z   github.com/coder/coder/v2/cli_test.TestUpdateWithRichParameters()
2025-03-26T17:33:04.6861885Z       /home/runner/work/coder/coder/cli/update_test.go:112 +0x904
2025-03-26T17:33:04.6862211Z   testing.tRunner()
2025-03-26T17:33:04.6862618Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1792 +0x225
2025-03-26T17:33:04.6862985Z   testing.(*T).Run.gowrap1()
2025-03-26T17:33:04.6863392Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x44
2025-03-26T17:33:04.6863650Z 
2025-03-26T17:33:04.6863761Z Goroutine 9889 (running) created at:
2025-03-26T17:33:04.6864025Z   testing.(*T).Run()
2025-03-26T17:33:04.6864424Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x8f2
2025-03-26T17:33:04.6864902Z   github.com/coder/coder/v2/cli_test.TestUpdateWithRichParameters()
2025-03-26T17:33:04.6865480Z       /home/runner/work/coder/coder/cli/update_test.go:228 +0x9f8
2025-03-26T17:33:04.6865819Z   testing.tRunner()
2025-03-26T17:33:04.6866226Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1792 +0x225
2025-03-26T17:33:04.6866593Z   testing.(*T).Run.gowrap1()
2025-03-26T17:33:04.6867031Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x44
2025-03-26T17:33:04.6867356Z ==================

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions