-
Notifications
You must be signed in to change notification settings - Fork 952
feat(cli): add CLI support for creating a workspace with preset #18912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ssncferreira
wants to merge
8
commits into
main
Choose a base branch
from
ssncferreira/cli-create-preset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,109
−3
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
982031a
feat(cli): add CLI support for creating a workspace with preset
ssncferreira ae16155
chore: fix presetParameterAsWorkspaceBuildParameters function
ssncferreira 3d7b40e
chore: minor fixes
ssncferreira 7159de2
Merge remote-tracking branch 'origin/main' into ssncferreira/cli-crea…
ssncferreira b8a1c14
chore: fix merge orgin/main
ssncferreira 77a72b1
chore: prompt user to select a preset when no --preset flag is provided
ssncferreira cffe049
chore: update preset flag description
ssncferreira ac12e0a
Merge remote-tracking branch 'origin/main' into ssncferreira/cli-crea…
ssncferreira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nonblocking: chaining this call to promptPresetSelection here has a few coupling related downsides:
If possible, it would perhaps be better to return something here that means "no preset resolved" and then call the prompt outside.