minor fixes

evgeniy-scherbina · evgeniy-scherbina · commit ff41e182b9cc · 2025-06-11T20:52:37.000Z
diff --git a/coderd/prebuilds/preset_snapshot.go b/coderd/prebuilds/preset_snapshot.go
@@ -5,15 +5,12 @@ import (
 	"slices"
 	"time"
 
-	"golang.org/x/xerrors"
-
-	"github.com/coder/coder/v2/coderd/schedule/cron"
-
-	"github.com/google/uuid"
-
 	"github.com/coder/quartz"
+	"github.com/google/uuid"
+	"golang.org/x/xerrors"
 
 	"github.com/coder/coder/v2/coderd/database"
+	"github.com/coder/coder/v2/coderd/schedule/cron"
 )
 
 // ActionType represents the type of action needed to reconcile prebuilds.
@@ -106,16 +103,19 @@ func MatchesCron(cronExpression string, at time.Time) (bool, error) {
 // Otherwise, it falls back to the default number of instances specified in the prebuild configuration.
 func (p PresetSnapshot) CalculateDesiredInstances(at time.Time) (int32, error) {
 	if len(p.PrebuildSchedules) == 0 {
+		// If no schedules are defined, fall back to the default desired instance count
 		return p.Preset.DesiredInstances.Int32, nil
 	}
 
+	// Validate that the provided timezone is valid
 	_, err := time.LoadLocation(p.Preset.AutoscalingTimezone)
 	if err != nil {
 		return 0, xerrors.Errorf("failed to parse location %v: %w", p.Preset.AutoscalingTimezone, err)
 	}
 
-	// Check each schedule
+	// Look for a schedule whose cron expression matches the provided time
 	for _, schedule := range p.PrebuildSchedules {
+		// Prefix the cron expression with timezone information
 		cronExprWithTimezone := fmt.Sprintf("CRON_TZ=%s %s", p.Preset.AutoscalingTimezone, schedule.CronExpression)
 		matches, err := MatchesCron(cronExprWithTimezone, at)
 		if err != nil {
@@ -126,6 +126,7 @@ func (p PresetSnapshot) CalculateDesiredInstances(at time.Time) (int32, error) {
 		}
 	}
 
+	// If no schedule matches, fall back to the default desired instance count
 	return p.Preset.DesiredInstances.Int32, nil
 }
 
@@ -160,8 +161,9 @@ func (p PresetSnapshot) CalculateState() *ReconciliationState {
 		var err error
 		desired, err = p.CalculateDesiredInstances(p.clock.Now())
 		if err != nil {
-			// TODO: handle error
-			panic(err)
+			// In case of an error, fall back to the default desired instance count
+			desired = p.Preset.DesiredInstances.Int32
+			// TODO: log error
 		}
 		eligible = p.countEligible()
 		extraneous = max(actual-expired-desired, 0)
