initial frontend updates

bcpeinhardt · bcpeinhardt · commit f6134aa94cdf · 2025-07-15T21:40:55.000Z
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -903,6 +903,12 @@ func (s *server) UpdateJob(ctx context.Context, request *proto.UpdateJobRequest)
 	}
 
 	if len(request.Logs) > 0 {
+		if job.LogsOverflowed {
+			return &proto.UpdateJobResponse{
+				Canceled: job.CanceledAt.Valid,
+			}, nil
+		}
+
 		//nolint:exhaustruct // We append to the additional fields below.
 		insertParams := database.InsertProvisionerJobLogsParams{
 			JobID: parsedID,
diff --git a/coderd/provisionerdserver/provisionerdserver_test.go b/coderd/provisionerdserver/provisionerdserver_test.go
@@ -1018,6 +1018,51 @@ func TestUpdateJob(t *testing.T) {
 		require.Equal(t, expectedSize, jobResult.LogsLength)
 		require.False(t, jobResult.LogsOverflowed)
 	})
+
+	t.Run("LogOverflowStopsProcessing", func(t *testing.T) {
+		t.Parallel()
+		srv, db, _, pd := setup(t, false, &overrides{})
+		job := setupJob(t, db, pd.ID, pd.Tags)
+
+		// First: trigger overflow
+		largeOutput := strings.Repeat("a", 1048577) // 1MB + 1 byte
+		_, err := srv.UpdateJob(ctx, &proto.UpdateJobRequest{
+			JobId: job.String(),
+			Logs: []*proto.Log{{
+				Source: proto.LogSource_PROVISIONER,
+				Level:  sdkproto.LogLevel_INFO,
+				Output: largeOutput,
+			}},
+		})
+		require.NoError(t, err)
+
+		// Get the initial log count
+		initialLogs, err := db.GetProvisionerLogsAfterID(ctx, database.GetProvisionerLogsAfterIDParams{
+			JobID:        job,
+			CreatedAfter: -1,
+		})
+		require.NoError(t, err)
+		initialCount := len(initialLogs)
+
+		// Second: try to send more logs - should be ignored
+		_, err = srv.UpdateJob(ctx, &proto.UpdateJobRequest{
+			JobId: job.String(),
+			Logs: []*proto.Log{{
+				Source: proto.LogSource_PROVISIONER,
+				Level:  sdkproto.LogLevel_INFO,
+				Output: "this should be ignored",
+			}},
+		})
+		require.NoError(t, err)
+
+		// Verify no new logs were added
+		finalLogs, err := db.GetProvisionerLogsAfterID(ctx, database.GetProvisionerLogsAfterIDParams{
+			JobID:        job,
+			CreatedAfter: -1,
+		})
+		require.NoError(t, err)
+		require.Equal(t, initialCount, len(finalLogs))
+	})
 }
 
 func TestFailJob(t *testing.T) {
diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
diff --git a/site/src/modules/workspaces/WorkspaceBuildLogs/WorkspaceBuildLogs.tsx b/site/src/modules/workspaces/WorkspaceBuildLogs/WorkspaceBuildLogs.tsx
@@ -1,9 +1,9 @@
 import { type Interpolation, type Theme, useTheme } from "@emotion/react";
-import type { ProvisionerJobLog } from "api/typesGenerated";
+import type { ProvisionerJobLog, WorkspaceBuild } from "api/typesGenerated";
 import type { Line } from "components/Logs/LogLine";
 import { DEFAULT_LOG_LINE_SIDE_PADDING, Logs } from "components/Logs/Logs";
 import dayjs from "dayjs";
-import { type FC, Fragment, type HTMLAttributes } from "react";
+import { type FC, Fragment, type HTMLAttributes, useMemo } from "react";
 import { BODY_FONT_FAMILY, MONOSPACE_FONT_FAMILY } from "theme/constants";
 
 const Language = {
@@ -42,15 +42,36 @@ interface WorkspaceBuildLogsProps extends HTMLAttributes<HTMLDivElement> {
 	hideTimestamps?: boolean;
 	sticky?: boolean;
 	logs: ProvisionerJobLog[];
+	build?: WorkspaceBuild;
 }
 
 export const WorkspaceBuildLogs: FC<WorkspaceBuildLogsProps> = ({
 	hideTimestamps,
 	sticky,
 	logs,
+	build,
 	...attrs
 }) => {
 	const theme = useTheme();
+
+	const processedLogs = useMemo(() => {
+		const allLogs = logs || [];
+
+		// Add synthetic overflow message if needed
+		if (build?.job?.logs_overflowed) {
+			allLogs.push({
+				id: -1,
+				created_at: new Date().toISOString(),
+				log_level: "error",
+				log_source: "provisioner",
+				output: "Provisioner logs exceeded the max size of 1MB!",
+				stage: "overflow",
+			});
+		}
+
+		return allLogs;
+	}, [logs, build?.job?.logs_overflowed]);
+
 	const groupedLogsByStage = groupLogsByStage(logs);
 
 	return (
diff --git a/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPageView.tsx b/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPageView.tsx
@@ -212,7 +212,24 @@ export const WorkspaceBuildPageView: FC<WorkspaceBuildPageViewProps> = ({
 						</Alert>
 					)}
 
-					{tabState.value === "build" && <BuildLogsContent logs={logs} />}
+					{build?.job?.logs_overflowed && (
+						<Alert
+							severity="warning"
+							css={{
+								borderRadius: 0,
+								border: 0,
+								background: theme.roles.warning.background,
+								borderBottom: `1px solid ${theme.palette.divider}`,
+							}}
+						>
+							Provisioner logs exceeded the maximum size of 1MB and were
+							truncated.
+						</Alert>
+					)}
+
+					{tabState.value === "build" && (
+						<BuildLogsContent logs={logs} build={build} />
+					)}
 					{tabState.value !== "build" && selectedAgent && (
 						<AgentLogsContent agent={selectedAgent} />
 					)}
@@ -261,7 +278,10 @@ const ScrollArea: FC<HTMLProps<HTMLDivElement>> = (props) => {
 	);
 };
 
-const BuildLogsContent: FC<{ logs?: ProvisionerJobLog[] }> = ({ logs }) => {
+const BuildLogsContent: FC<{
+	logs?: ProvisionerJobLog[];
+	build?: WorkspaceBuild;
+}> = ({ logs, build }) => {
 	if (!logs) {
 		return <Loader />;
 	}
@@ -278,6 +298,7 @@ const BuildLogsContent: FC<{ logs?: ProvisionerJobLog[] }> = ({ logs }) => {
 				},
 			}}
 			logs={sortLogsByCreatedAt(logs)}
+			build={build}
 		/>
 	);
 };
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -689,6 +689,7 @@ export const MockProvisionerJob: TypesGen.ProvisionerJob = {
 		template_version_name: "test-version",
 		workspace_name: "test-workspace",
 	},
+	logs_overflowed: false,
 };
 
 export const MockFailedProvisionerJob: TypesGen.ProvisionerJob = {
