refactor: extract PrebuiltWorkspaceResource interface for prebuilt RBAC support

ssncferreira · ssncferreira · commit f3f01830e760 · 2025-06-24T11:33:31.000Z
diff --git a/coderd/database/modelmethods.go b/coderd/database/modelmethods.go
@@ -199,6 +199,13 @@ func (gm GroupMember) RBACObject() rbac.Object {
 	return rbac.ResourceGroupMember.WithID(gm.UserID).InOrg(gm.OrganizationID).WithOwner(gm.UserID.String())
 }
 
+// PrebuiltWorkspaceResource defines the interface for types that can be identified as prebuilt workspaces
+// and converted to their corresponding prebuilt workspace RBAC object.
+type PrebuiltWorkspaceResource interface {
+	IsPrebuild() bool
+	AsPrebuild() rbac.Object
+}
+
 // WorkspaceTable converts a Workspace to it's reduced version.
 // A more generalized solution is to use json marshaling to
 // consistently keep these two structs in sync.
diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -396,10 +396,7 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) {
 				}
 				// Special handling for prebuilt workspace deletion
 				if action == policy.ActionDelete {
-					if workspaceObj, ok := object.(interface {
-						IsPrebuild() bool
-						AsPrebuild() rbac.Object
-					}); ok && workspaceObj.IsPrebuild() {
+					if workspaceObj, ok := object.(database.PrebuiltWorkspaceResource); ok && workspaceObj.IsPrebuild() {
 						return api.Authorize(r, action, workspaceObj.AsPrebuild())
 					}
 				}

Original file line number	Diff line number	Diff line change
`@@ -396,10 +396,7 @@ func (api API) postWorkspaceBuilds(rw http.ResponseWriter, r http.Request) {`
`396`	`396`	`}`
`397`	`397`	`// Special handling for prebuilt workspace deletion`
`398`	`398`	`if action == policy.ActionDelete {`
`399`		`- if workspaceObj, ok := object.(interface {`
`400`		`- IsPrebuild() bool`
`401`		`- AsPrebuild() rbac.Object`
`402`		`- }); ok && workspaceObj.IsPrebuild() {`
	`399`	`+ if workspaceObj, ok := object.(database.PrebuiltWorkspaceResource); ok && workspaceObj.IsPrebuild() {`
`403`	`400`	`return api.Authorize(r, action, workspaceObj.AsPrebuild())`
`404`	`401`	`}`
`405`	`402`	`}`