fix: handle blink changes

jaaydenh · jaaydenh · commit d875f02b5811 · 2025-07-23T17:17:25.000Z
diff --git a/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx b/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx
@@ -215,20 +215,19 @@ export const MultiSelectCombobox = forwardRef<
 		const dropdownRef = useRef<HTMLDivElement>(null);
 
 		const [selected, setSelected] = useState<Option[]>(
-			arrayDefaultOptions ?? [],
+			value ?? arrayDefaultOptions ?? [],
 		);
 		const [options, setOptions] = useState<GroupOption>(
 			transitionToGroupOption(arrayDefaultOptions, groupBy),
 		);
 		const [inputValue, setInputValue] = useState("");
 		const debouncedSearchTerm = useDebouncedValue(inputValue, delay || 500);
 
-		// Handle controlled value prop
-		useEffect(() => {
-			if (value) {
-				setSelected(value);
-			}
-		}, [value]);
+		const [previousValue, setPreviousValue] = useState<Option[]>(value || []);
+		if (value && value !== previousValue) {
+			setPreviousValue(value);
+			setSelected(value);
+		}
 
 		useImperativeHandle(
 			ref,
