Skip to content

Commit b1aff3f

Browse files
committed
Collect all todo testcases in a single file
1 parent 0f53056 commit b1aff3f

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

coderd/presets_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,14 @@ import (
1515
)
1616

1717
func TestTemplateVersionPresets(t *testing.T) {
18+
// TODO (sasswart): test case: what if immutable parameters are used in the preset?
19+
// TODO (sasswart): test case: what if presets are defined for a template version with no params?
20+
// TODO (sasswart): test case: what if a non active version is selected?
21+
// TODO (sasswart): test case: what if a preset is selected that has no parameters?
22+
// TODO (sasswart): what if we have preset params and autofill params on the same param?
23+
// TODO (sasswart): test case: if we move from preset to no preset, do we reset the params?
24+
// If so, how should it behave? Reset to initial value? reset to last set value?
25+
// TODO (sasswart): test case: rich parameters
1826
// TODO (sasswart): Test case: what if a user tries to read presets or preset parameters from a different org?
1927

2028
t.Parallel()

site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -164,15 +164,6 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
164164
);
165165

166166
useEffect(() => {
167-
// TODO (sasswart): test case: what if immutable parameters are used in the preset?
168-
// TODO (sasswart): test case: what if presets are defined for a template version with no params?
169-
// TODO (sasswart): test case: what if a non active version is selected?
170-
// TODO (sasswart): test case: what if a preset is selected that has no parameters?
171-
// TODO (sasswart): what if we have preset params and autofill params on the same param?
172-
// TODO (sasswart): test case: if we move from preset to no preset, do we reset the params?
173-
// If so, how should it behave? Reset to initial value? reset to last set value?
174-
// TODO (sasswart): test case: rich parameters
175-
176167
const selectedPresetOption = presetOptions[selectedPresetIndex];
177168
let selectedPreset: TypesGen.Preset | undefined;
178169
for (const preset of presets) {

0 commit comments

Comments
 (0)