fix: simplify proxy state initialization to avoid temporal dead zone

blink-so[bot] · kylecarbs · blink-so[bot] · commit abcdccc4f8d9 · 2025-07-17T21:41:32.000Z
The useState initializer was trying to access userSavedProxy and proxiesResp
before they were available, causing a temporal dead zone issue. Simplified
to use only localStorage for initial state and let useEffect handle updates.

Co-authored-by: kylecarbs &lt;7122116+kylecarbs@users.noreply.github.com&gt;
diff --git a/site/src/contexts/ProxyContext.tsx b/site/src/contexts/ProxyContext.tsx
@@ -128,16 +128,11 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
 		return loadUserSelectedProxy();
 	}, [userProxyQuery.data, proxiesResp]);
 
-	// Load the initial state from user preferences or localStorage.
-	// Use safe initialization to avoid temporal dead zone with userSavedProxy
-	const [proxy, setProxy] = useState<PreferredProxy>(() => {
-		// Only use userSavedProxy if proxiesResp is available
-		if (proxiesResp && userSavedProxy) {
-			return computeUsableURLS(userSavedProxy);
-		}
-		// Safe fallback - let useEffect handle proper initialization
-		return computeUsableURLS(undefined);
-	});
+	// Load the initial state from localStorage only
+	// Let useEffect handle proper initialization when data is available
+	const [proxy, setProxy] = useState<PreferredProxy>(
+		computeUsableURLS(loadUserSelectedProxy()),
+	);
 
 	const { permissions } = useAuthenticated();
 	const { metadata } = useEmbeddedMetadata();
