Skip to content

Commit 9239251

Browse files
committed
tooltip
1 parent 2cc8f29 commit 9239251

File tree

4 files changed

+42
-5
lines changed

4 files changed

+42
-5
lines changed

site/src/api/api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1805,7 +1805,7 @@ class ApiMethods {
18051805
getConnectionLogs = async (
18061806
options: TypesGen.ConnectionLogsRequest,
18071807
): Promise<TypesGen.ConnectionLogResponse> => {
1808-
const url = getURLWithSearchParams("/api/v2/connectionlogs", options);
1808+
const url = getURLWithSearchParams("/api/v2/connectionlog", options);
18091809
const response = await this.axios.get(url);
18101810
return response.data;
18111811
};

site/src/pages/ConnectionLogPage/ConnectionLogFilter.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
} from "modules/tableFiltering/options";
1717
import type { FC } from "react";
1818
import { connectionTypeToFriendlyName } from "utils/connection";
19+
import { docs } from "utils/docs";
1920

2021
const PRESET_FILTERS = [
2122
{
@@ -45,8 +46,7 @@ export const ConnectionLogFilter: FC<ConnectionLogFilterProps> = ({
4546

4647
return (
4748
<Filter
48-
// TODO(ethanndickson): Add docs
49-
// learnMoreLink={docs("/admin/security/connection-logs#filtering-logs")}
49+
learnMoreLink={docs("/admin/security/connection-logs#filtering-logs")}
5050
presets={PRESET_FILTERS}
5151
isLoading={menus.user.isInitializing}
5252
filter={filter}
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
import {
2+
HelpTooltip,
3+
HelpTooltipContent,
4+
HelpTooltipLink,
5+
HelpTooltipLinksGroup,
6+
HelpTooltipText,
7+
HelpTooltipTitle,
8+
HelpTooltipTrigger,
9+
} from "components/HelpTooltip/HelpTooltip";
10+
import type { FC } from "react";
11+
import { docs } from "utils/docs";
12+
13+
const Language = {
14+
title: "Why are some events missing?",
15+
body: "The connection log is a best-effort log of workspace access. Some events are reported by workspace agents, and receipt of these events by the server is not guaranteed.",
16+
docs: "Connection log documentation",
17+
};
18+
19+
export const ConnectionLogHelpTooltip: FC = () => {
20+
return (
21+
<HelpTooltip>
22+
<HelpTooltipTrigger />
23+
24+
<HelpTooltipContent>
25+
<HelpTooltipTitle>{Language.title}</HelpTooltipTitle>
26+
<HelpTooltipText>{Language.body}</HelpTooltipText>
27+
<HelpTooltipLinksGroup>
28+
<HelpTooltipLink href={docs("/admin/security/connection-logs")}>
29+
{Language.docs}
30+
</HelpTooltipLink>
31+
</HelpTooltipLinksGroup>
32+
</HelpTooltipContent>
33+
</HelpTooltip>
34+
);
35+
};

site/src/pages/ConnectionLogPage/ConnectionLogPageView.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ import { Stack } from "components/Stack/Stack";
2121
import { TableLoader } from "components/TableLoader/TableLoader";
2222
import { Timeline } from "components/Timeline/Timeline";
2323
import type { ComponentProps, FC } from "react";
24+
import { docs } from "utils/docs";
2425
import { ConnectionLogFilter } from "./ConnectionLogFilter";
26+
import { ConnectionLogHelpTooltip } from "./ConnectionLogHelpTooltip";
2527
import { ConnectionLogRow } from "./ConnectionLogRow/ConnectionLogRow";
2628

2729
const Language = {
@@ -59,6 +61,7 @@ export const ConnectionLogPageView: FC<ConnectionLogPageViewProps> = ({
5961
<PageHeaderTitle>
6062
<Stack direction="row" spacing={1} alignItems="center">
6163
<span>{Language.title}</span>
64+
<ConnectionLogHelpTooltip />
6265
</Stack>
6366
</PageHeaderTitle>
6467
<PageHeaderSubtitle>{Language.subtitle}</PageHeaderSubtitle>
@@ -134,8 +137,7 @@ export const ConnectionLogPageView: FC<ConnectionLogPageViewProps> = ({
134137
<Paywall
135138
message="Connection logs"
136139
description="Connection logs allow you to see how and when users connect to workspaces. You need a Premium license to use this feature."
137-
// TODO(ethanndickson): docs
138-
// documentationLink={docs("/admin/security/connection-logs")}
140+
documentationLink={docs("/admin/security/connection-logs")}
139141
/>
140142
</Cond>
141143
</ChooseOne>

0 commit comments

Comments
 (0)