Skip to content

Commit 91fd4e7

Browse files
chore: pass env variables + remove accidental commit
1 parent bcd6689 commit 91fd4e7

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

agent/agentcontainers/api.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1146,12 +1146,14 @@ func (api *API) maybeInjectSubAgentIntoContainerLocked(ctx context.Context, dc c
11461146

11471147
var apps []SubAgentApp
11481148

1149-
if config, err := api.dccli.ReadConfig(ctx, dc.WorkspaceFolder, dc.ConfigPath, []string{
1150-
fmt.Sprintf("CODER_AGENT_NAME=%s", dc.Name),
1151-
fmt.Sprintf("CODER_USER_NAME=%s", api.userName),
1152-
fmt.Sprintf("CODER_WORKSPACE_NAME=%s", api.workspaceName),
1153-
fmt.Sprintf("CODER_DEPLOYMENT_URL=%s", api.subAgentURL),
1154-
}); err != nil {
1149+
if config, err := api.dccli.ReadConfig(ctx, dc.WorkspaceFolder, dc.ConfigPath,
1150+
[]string{
1151+
fmt.Sprintf("CODER_WORKSPACE_AGENT_NAME=%s", dc.Name),
1152+
fmt.Sprintf("CODER_WORKSPACE_OWNER_NAME=%s", api.userName),
1153+
fmt.Sprintf("CODER_WORKSPACE_NAME=%s", api.workspaceName),
1154+
fmt.Sprintf("CODER_DEPLOYMENT_URL=%s", api.subAgentURL),
1155+
},
1156+
); err != nil {
11551157
api.logger.Error(ctx, "unable to read devcontainer config", slog.Error(err))
11561158
} else {
11571159
coderCustomization := config.MergedConfiguration.Customizations.Coder

agent/agentcontainers/devcontainercli.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"encoding/json"
88
"errors"
99
"io"
10+
"os"
1011

1112
"golang.org/x/xerrors"
1213

@@ -264,7 +265,7 @@ func (d *devcontainerCLI) ReadConfig(ctx context.Context, workspaceFolder, confi
264265
}
265266

266267
c := d.execer.CommandContext(ctx, "devcontainer", args...)
267-
// c.Env = append(c.Env, env...)
268+
c.Env = append(os.Environ(), env...)
268269

269270
var stdoutBuf bytes.Buffer
270271
stdoutWriters := []io.Writer{&stdoutBuf, &devcontainerCLILogWriter{ctx: ctx, logger: logger.With(slog.F("stdout", true))}}

site/src/pages/WorkspacePage/Workspace.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,6 @@ export const Workspace: FC<WorkspaceProps> = ({
9999
const shouldShowProvisionerAlert =
100100
workspacePending && !haveBuildLogs && !provisionersHealthy && !isRestarting;
101101

102-
console.log(selectedResource?.agents);
103-
104102
return (
105103
<div
106104
css={{

0 commit comments

Comments
 (0)