Skip to content

Commit 4980780

Browse files
committed
fix: slider improvements
1 parent b2f30fc commit 4980780

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -411,23 +411,27 @@ const DebouncedParameterField: FC<DebouncedParameterFieldProps> = ({
411411
}
412412

413413
case "slider":
414+
const numericValue = Number.isFinite(Number(localValue)) ? Number(localValue) : 0;
415+
const {
416+
validation_min: min = 0,
417+
validation_max: max = 100,
418+
} = parameter.validations[0] ?? {};
419+
414420
return (
415421
<div className="flex flex-row items-baseline gap-3">
416422
<Slider
417423
id={id}
418424
className="mt-2"
419-
value={[
420-
Number.isFinite(Number(localValue)) ? Number(localValue) : 0,
421-
]}
425+
value={[numericValue]}
422426
onValueChange={([value]) => {
423427
setLocalValue(value.toString());
424428
}}
425-
min={parameter.validations[0]?.validation_min ?? 0}
426-
max={parameter.validations[0]?.validation_max ?? 100}
429+
min={min ?? undefined}
430+
max={max ?? undefined}
427431
disabled={disabled}
428432
/>
429433
<span className="w-4 font-medium">
430-
{Number.isFinite(Number(localValue)) ? localValue : "0"}
434+
{numericValue}
431435
</span>
432436
</div>
433437
);

0 commit comments

Comments
 (0)