refactor: simplify workspace type assertion

ssncferreira · ssncferreira · commit 2c387ce20ef9 · 2025-06-24T09:23:38.000Z
diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -397,8 +397,11 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) {
 					return true
 				}
 				// Special handling for prebuilt workspace deletion
-				if object.RBACObject().Type == rbac.ResourceWorkspace.Type && action == policy.ActionDelete {
-					if workspaceObj, ok := object.(database.Workspace); ok && workspaceObj.IsPrebuild() {
+				if action == policy.ActionDelete {
+					if workspaceObj, ok := object.(interface {
+						IsPrebuild() bool
+						AsPrebuild() rbac.Object
+					}); ok && workspaceObj.IsPrebuild() {
 						return api.Authorize(r, action, workspaceObj.AsPrebuild())
 					}
 				}

Original file line number	Diff line number	Diff line change
`@@ -397,8 +397,11 @@ func (api API) postWorkspaceBuilds(rw http.ResponseWriter, r http.Request) {`
`397`	`397`	`return true`
`398`	`398`	`}`
`399`	`399`	`// Special handling for prebuilt workspace deletion`
`400`		`- if object.RBACObject().Type == rbac.ResourceWorkspace.Type && action == policy.ActionDelete {`
`401`		`- if workspaceObj, ok := object.(database.Workspace); ok && workspaceObj.IsPrebuild() {`
	`400`	`+ if action == policy.ActionDelete {`
	`401`	`+ if workspaceObj, ok := object.(interface {`
	`402`	`+ IsPrebuild() bool`
	`403`	`+ AsPrebuild() rbac.Object`
	`404`	`+ }); ok && workspaceObj.IsPrebuild() {`
`402`	`405`	`return api.Authorize(r, action, workspaceObj.AsPrebuild())`
`403`	`406`	`}`
`404`	`407`	`}`