fix: restore original proxy auto-selection logic

blink-so[bot] · kylecarbs · blink-so[bot] · commit 1697b42d4761 · 2025-07-17T21:55:28.000Z
Revert useEffect dependency arrays to match main branch behavior:
- Remove userSavedProxy from dependency arrays
- Call loadUserSelectedProxy() directly in auto-selection logic
- This ensures auto-selection works when no user proxy is saved

Co-authored-by: kylecarbs &lt;7122116+kylecarbs@users.noreply.github.com&gt;
diff --git a/site/src/contexts/ProxyContext.tsx b/site/src/contexts/ProxyContext.tsx
@@ -156,7 +156,7 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
 	// biome-ignore lint/correctness/useExhaustiveDependencies: Only update if the source data changes
 	useEffect(() => {
 		updateProxy();
-	}, [proxiesResp, proxyLatencies, userSavedProxy]);
+	}, [proxiesResp, proxyLatencies]);
 
 	// This useEffect will auto select the best proxy if the user has not selected one.
 	// It must wait until all latencies are loaded to select based on latency. This does mean
@@ -165,7 +165,7 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
 	// Once the page is loaded, or the user selects a proxy, this will not run again.
 	// biome-ignore lint/correctness/useExhaustiveDependencies: Only update if the source data changes
 	useEffect(() => {
-		if (userSavedProxy !== undefined) {
+		if (loadUserSelectedProxy() !== undefined) {
 			return; // User has selected a proxy, do not auto select.
 		}
 		if (!latenciesLoaded) {
@@ -175,7 +175,7 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
 
 		const best = getPreferredProxy(
 			proxiesResp ?? [],
-			userSavedProxy,
+			loadUserSelectedProxy(),
 			proxyLatencies,
 			true,
 		);
@@ -184,7 +184,7 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
 			saveUserSelectedProxy(best.proxy);
 			updateProxy();
 		}
-	}, [latenciesLoaded, proxiesResp, proxyLatencies, userSavedProxy]);
+	}, [latenciesLoaded, proxiesResp, proxyLatencies]);
 
 	return (
 		<ProxyContext.Provider
