test: fix CI and dbmem

evgeniy-scherbina · evgeniy-scherbina · commit 147b22dcb99c · 2025-07-08T21:02:15.000Z
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
@@ -5777,8 +5777,7 @@ func (s *MethodTestSuite) TestUserSecrets() {
 			UserID: user.ID,
 		}
 		check.Args(arg).
-			Asserts(rbac.ResourceUserSecret.WithOwner(arg.UserID.String()), policy.ActionCreate).
-			ErrorsWithInMemDB(dbmem.ErrUnimplemented)
+			Asserts(rbac.ResourceUserSecret.WithOwner(arg.UserID.String()), policy.ActionCreate)
 	}))
 	s.Run("GetUserSecret", s.Subtest(func(db database.Store, check *expects) {
 		user := dbgen.User(s.T(), db, database.User{})
@@ -5791,7 +5790,6 @@ func (s *MethodTestSuite) TestUserSecrets() {
 		}
 		check.Args(arg).
 			Asserts(rbac.ResourceUserSecret.WithOwner(arg.UserID.String()), policy.ActionRead).
-			ErrorsWithInMemDB(dbmem.ErrUnimplemented).
 			Returns(userSecret)
 	}))
 	s.Run("ListUserSecrets", s.Subtest(func(db database.Store, check *expects) {
@@ -5801,7 +5799,6 @@ func (s *MethodTestSuite) TestUserSecrets() {
 		})
 		check.Args(user.ID).
 			Asserts(rbac.ResourceUserSecret.WithOwner(user.ID.String()), policy.ActionRead).
-			ErrorsWithInMemDB(dbmem.ErrUnimplemented).
 			Returns([]database.UserSecret{userSecret})
 	}))
 }
diff --git a/coderd/database/dbgen/dbgen.go b/coderd/database/dbgen/dbgen.go
@@ -1372,7 +1372,7 @@ func UserSecret(t testing.TB, db database.Store, seed database.InsertUserSecretP
 		Value:       takeFirst(seed.Value, "secret value"),
 		ValueKeyID:  takeFirst(seed.ValueKeyID, sql.NullString{}),
 	})
-	require.NoError(t, err, "insert user secret")
+	require.NoError(t, err, "failed to insert user secret")
 	return userSecret
 }
 
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -74,6 +74,7 @@ func New() database.Store {
 			presets:                        make([]database.TemplateVersionPreset, 0),
 			presetParameters:               make([]database.TemplateVersionPresetParameter, 0),
 			presetPrebuildSchedules:        make([]database.TemplateVersionPresetPrebuildSchedule, 0),
+			userSecrets:                    make([]database.UserSecret, 0),
 			provisionerDaemons:             make([]database.ProvisionerDaemon, 0),
 			provisionerJobs:                make([]database.ProvisionerJob, 0),
 			provisionerJobLogs:             make([]database.ProvisionerJobLog, 0),
@@ -297,6 +298,7 @@ type data struct {
 	presets                          []database.TemplateVersionPreset
 	presetParameters                 []database.TemplateVersionPresetParameter
 	presetPrebuildSchedules          []database.TemplateVersionPresetPrebuildSchedule
+	userSecrets                      []database.UserSecret
 	prebuildsSettings                []byte
 }
 
@@ -6805,7 +6807,16 @@ func (q *FakeQuerier) GetUserSecret(ctx context.Context, arg database.GetUserSec
 		return database.UserSecret{}, err
 	}
 
-	panic("not implemented")
+	q.mutex.RLock()
+	defer q.mutex.RUnlock()
+
+	for _, secret := range q.userSecrets {
+		if secret.UserID == arg.UserID && secret.Name == arg.Name {
+			return secret, nil
+		}
+	}
+
+	return database.UserSecret{}, fmt.Errorf("secret %v for user %v not found", arg.Name, arg.UserID)
 }
 
 func (q *FakeQuerier) GetUserStatusCounts(_ context.Context, arg database.GetUserStatusCountsParams) ([]database.GetUserStatusCountsRow, error) {
@@ -9725,7 +9736,21 @@ func (q *FakeQuerier) InsertUserSecret(ctx context.Context, arg database.InsertU
 		return database.UserSecret{}, err
 	}
 
-	return database.UserSecret{}, ErrUnimplemented
+	q.mutex.Lock()
+	defer q.mutex.Unlock()
+
+	userSecret := database.UserSecret{
+		ID:          uuid.New(),
+		UserID:      arg.UserID,
+		Name:        arg.Name,
+		Description: arg.Description,
+		Value:       arg.Value,
+		ValueKeyID:  arg.ValueKeyID,
+		CreatedAt:   time.Now(),
+		UpdatedAt:   time.Now(),
+	}
+	q.userSecrets = append(q.userSecrets, userSecret)
+	return userSecret, nil
 }
 
 func (q *FakeQuerier) InsertVolumeResourceMonitor(_ context.Context, arg database.InsertVolumeResourceMonitorParams) (database.WorkspaceAgentVolumeResourceMonitor, error) {
@@ -10286,7 +10311,17 @@ func (q *FakeQuerier) ListProvisionerKeysByOrganizationExcludeReserved(_ context
 }
 
 func (q *FakeQuerier) ListUserSecrets(ctx context.Context, userID uuid.UUID) ([]database.UserSecret, error) {
-	panic("not implemented")
+	q.mutex.RLock()
+	defer q.mutex.RUnlock()
+
+	filteredUserSecrets := make([]database.UserSecret, 0)
+	for _, secret := range q.userSecrets {
+		if secret.UserID == userID {
+			filteredUserSecrets = append(filteredUserSecrets, secret)
+		}
+	}
+
+	return filteredUserSecrets, nil
 }
 
 func (q *FakeQuerier) ListWorkspaceAgentPortShares(_ context.Context, workspaceID uuid.UUID) ([]database.WorkspaceAgentPortShare, error) {

Original file line number	Diff line number	Diff line change
`@@ -1372,7 +1372,7 @@ func UserSecret(t testing.TB, db database.Store, seed database.InsertUserSecretP`
`1372`	`1372`	`Value: takeFirst(seed.Value, "secret value"),`
`1373`	`1373`	`ValueKeyID: takeFirst(seed.ValueKeyID, sql.NullString{}),`
`1374`	`1374`	`})`
`1375`		`- require.NoError(t, err, "insert user secret")`
	`1375`	`+ require.NoError(t, err, "failed to insert user secret")`
`1376`	`1376`	`return userSecret`
`1377`	`1377`	`}`
`1378`	`1378`