-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Description
What is your suggestion?
I recently used your helm chart to deploy code-server with docker (dind) enabled. The existing example values were quite outdated and hence no longer worked.
For example, the most recent image is docker:28.3.2-dind
but the example shown in the values.yaml
file is docker:19.03-dind
. There were other fields that needed updating and figuring out which took some time.
I'd like to update the values.yaml
file with a more recent example that I know works.
How will this improve the docs?
Could add a snippet around looking into the values.yaml file if deploying on kubernetes and docker is required.
Are you interested in submitting a PR for this?
Yes! The PR will involve updating 1 file (potentially 2). The 1 main file to update is the values.yaml
file, and the fields that need updating are all commented out anyway. The other potential file is the FAQ.md
where I was thinking to add a paragraph under the existing ## Can I use Docker in a code-server container?
header.
Unfortunately I tried cloning, and creating a new branch, and pushing the branch but I get a permission denied error.