chore: add golangci lint

hugodutka · hugodutka · commit f1abbb1c4cd2 · 2025-07-22T15:58:44.000+02:00
diff --git a/.golangci.yml b/.golangci.yml
@@ -0,0 +1,12 @@
+version: "2"
+linters:
+  enable:
+    - exhaustive
+  settings:
+    exhaustive:
+      check:
+        - "switch"
+        - "map"
+    staticcheck:
+      checks:
+        - "-QF1001" # disable "could apply De Morgan's law"
diff --git a/cmd/attach/attach.go b/cmd/attach/attach.go
@@ -80,7 +80,9 @@ func ReadScreenOverHTTP(ctx context.Context, url string, ch chan<- httpapi.Scree
 	if err != nil {
 		return xerrors.Errorf("failed to do request: %w", err)
 	}
-	defer res.Body.Close()
+	defer func() {
+		_ = res.Body.Close()
+	}()
 
 	for ev, err := range sse.Read(res.Body, &sse.ReadConfig{
 		// 256KB: screen can be big. The default terminal size is 80x1000,
@@ -115,7 +117,9 @@ func WriteRawInputOverHTTP(ctx context.Context, url string, msg string) error {
 	if err != nil {
 		return xerrors.Errorf("failed to do request: %w", err)
 	}
-	defer res.Body.Close()
+	defer func() {
+		_ = res.Body.Close()
+	}()
 	if res.StatusCode != http.StatusOK {
 		return xerrors.Errorf("failed to write raw input: %w", errors.New(res.Status))
 	}
@@ -132,7 +136,9 @@ func runAttach(remoteUrl string) error {
 	if err != nil {
 		return xerrors.Errorf("failed to make raw: %w", err)
 	}
-	defer term.Restore(stdin, oldState)
+	defer func() {
+		_ = term.Restore(stdin, oldState)
+	}()
 
 	stdinWriter := &ChannelWriter{
 		ch: make(chan []byte, 4096),
diff --git a/lib/httpapi/embed.go b/lib/httpapi/embed.go
@@ -87,7 +87,9 @@ func FileServerWithIndexFallback(chatBasePath string) http.Handler {
 		// Try to serve the file directly
 		f, err := chatFS.Open(trimmedPath)
 		if err == nil {
-			defer f.Close()
+			defer func() {
+				_ = f.Close()
+			}()
 			fileServer.ServeHTTP(w, r)
 			return
 		}
diff --git a/lib/httpapi/server_test.go b/lib/httpapi/server_test.go
@@ -55,7 +55,9 @@ func TestOpenAPISchema(t *testing.T) {
 	if err != nil {
 		t.Fatalf("failed to open disk schema: %s", err)
 	}
-	defer diskSchemaFile.Close()
+	defer func() {
+		_ = diskSchemaFile.Close()
+	}()
 
 	diskSchemaBytes, err := io.ReadAll(diskSchemaFile)
 	if err != nil {
diff --git a/lib/screentracker/conversation_test.go b/lib/screentracker/conversation_test.go
@@ -186,7 +186,7 @@ func TestMessages(t *testing.T) {
 		assert.Equal(t, []st.ConversationMessage{
 			agentMsg(0, "1"),
 		}, msgs)
-		nowWrapper.Time = nowWrapper.Time.Add(1 * time.Second)
+		nowWrapper.Time = nowWrapper.Add(1 * time.Second)
 		c.AddSnapshot("1")
 		assert.Equal(t, msgs, c.Messages())
 	})
