feat: refactor output box #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. move toggle button to outputbox 2. fix dashboard loading
lihebi
reviewed
Nov 25, 2022
ui/src/pages/repos/index.tsx
Outdated
Comment on lines
299
to
308
| <Repos | ||
| callback={(arg) => { | ||
| if (arg) { | ||
| setError(arg); | ||
| } | ||
| }} | ||
| onLoading={(value) => { | ||
| setLoading(value); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
there is no issue, i just find that there are two loading hint. so i fixed it in the same time
There was a problem hiding this comment.
I see, let’s remove this, because this adds extra complexity. We’ll redirect to login page anyway, so there won’t be warnings. #77
There was a problem hiding this comment.
i remove error part, remain the loading part
There was a problem hiding this comment.
No worry. I'm taking over this part. But I want to confirm if it redirects the login page immediately or gives any hints and then jump to the login page?
There was a problem hiding this comment.
normally, it needs show hint firstly and then redirects
|
And your image link seems to be broken? |
lihebi
reviewed
Nov 29, 2022
Comment on lines
+295
to
+298
| <Repos | ||
| onLoading={(value)=>{ | ||
| setLoading(value) | ||
| }}/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue 74