Skip to content

remove CursorNode, fix pod center-on-selection #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Aug 18, 2023

Two changes:

@lihebi lihebi requested a review from senwang86 August 18, 2023 02:23
@lihebi
Copy link
Collaborator Author

lihebi commented Aug 18, 2023

Merging, FYI @senwang86

@lihebi lihebi merged commit 5bd42db into codepod-io:main Aug 18, 2023
@senwang86
Copy link
Collaborator

  • It used to have an issue by using SelectedPods since 1) it doesn't record the order of selection, and 2) it mixes the "single-selection" and "multi-selection". It might be the reason of the following bug,
  1. Mouseclick ScopeB
  2. Left arrow key, which goes to ScopeA
  3. Shift + Down arrow key, which goes to the first child of ScopeA
  4. Esc should go back to ScopeA, but it went back to ScopeB

jump_bugs

@lihebi
Copy link
Collaborator Author

lihebi commented Aug 18, 2023

4. Esc should go back to ScopeA, but it went back to ScopeB

Why Esc goes to parent? Do you mean shift+up?

@lihebi
Copy link
Collaborator Author

lihebi commented Aug 18, 2023

There shouldn’t be selection order problems, as there is only one pod being selected in the entire process.

@senwang86
Copy link
Collaborator

  1. Esc should go back to ScopeA, but it went back to ScopeB

Why Esc goes to parent? Do you mean shift+up?

Oh, my bad, forget that we don't use Esc during jump.

@senwang86
Copy link
Collaborator

There shouldn’t be selection order problems, as there is only one pod being selected in the entire process.

What would happen if you use keyboard to jump after you multi-select pods?

@lihebi
Copy link
Collaborator Author

lihebi commented Aug 18, 2023

It’s straight forward to determine the target pod by proximity. Then a jump should first reset the selection, then select the target pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants