[UI] Add Toc in Sidebar #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihebi
reviewed
Aug 15, 2023
ui/src/components/Sidebar.tsx
Outdated
Comment on lines
1234
to
1255
| function dfs( | ||
| nodeId: string, | ||
| toc: Map<string, ReactflowNode[]>, | ||
| nodesMap: Y.Map<ReactflowNode<NodeData>> | ||
| ) { | ||
| let jsx = <></>; | ||
|
|
||
| if (toc.has(nodeId) && toc.get(nodeId)!.length > 0) { | ||
| toc.get(nodeId)?.forEach((child) => { | ||
| jsx = ( | ||
| <> | ||
| {jsx} | ||
| <TocPodButton id={child.id} /> | ||
| {toc.has(child.id) ? <ul>{dfs(child.id, toc, nodesMap)}</ul> : null} | ||
| </> | ||
| ); | ||
| }); | ||
| } | ||
|
|
||
| return jsx; | ||
| } | ||
|
|
There was a problem hiding this comment.
This isn't "React style" code.
// Component must be CamelCase
function ToC({id}) {
if (!toc.has(id)) return null; // Return early
const children = toc.get(id)
return ( // directly return the Component, not assign and return a variable
<Box>
<TocPodButton id={child.id} />
{children.map(child=>(
// ToC is used directly as a component name.
// A non-CamelCase function cannot be used as a component name.
<ToC id={child}/>
))}
</Box>)
}
lihebi
reviewed
Aug 15, 2023
ui/src/components/Sidebar.tsx
Outdated
| <> | ||
| {jsx} | ||
| <TocPodButton id={child.id} /> | ||
| {toc.has(child.id) ? <ul>{dfs(child.id, toc, nodesMap)}</ul> : null} |
There was a problem hiding this comment.
You are using <ul> to control padding and using ListItem to show lists. These two things sound like two alternatives to achieve the same functionality, not to be used together.
How about using MUI's TreeView? It seems to offer a good padded UI with additional features such as folding and multi-selection.
There was a problem hiding this comment.
TreeView is indeed a better option.
|
Instead of showing (full) IDs, some options (ordered by priority, high to low):
|
1d71993 addresses comments. |
1d71993 addresses comments. |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test
yarn add @mui/lab @mui/material