Skip to content

Updated layout and added auto hide for output menu options #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

chimmyten
Copy link
Contributor

Changed the layout of the output menu options to vertical and put them on top of the output box. The menu options will only appear when the user's mouse hovers on the output box.

@lihebi
Copy link
Collaborator

lihebi commented Jun 9, 2023

Thanks, Timmy!

Two things:

  1. Can you use Prettier (with default config) to format your code? So that
    1. the code is consistent with our code base, and
    2. make sure the diff contains exactly the changes you made for easier review.
  2. Please attach a screenshot here to easily see the new UI

@chimmyten
Copy link
Contributor Author

No problem, I'll work on fixing that.

@chimmyten chimmyten closed this Jun 9, 2023
@lihebi
Copy link
Collaborator

lihebi commented Jun 9, 2023

You can just push to this branch , it will automatically update this PR.

@chimmyten chimmyten reopened this Jun 9, 2023
@chimmyten
Copy link
Contributor Author

Auto Hide Menu Changes

The new UI.
Please let me know if I need to make additional changes.

@lihebi
Copy link
Collaborator

lihebi commented Jun 10, 2023

Great PR. Thanks, Timmy!

@lihebi lihebi merged commit 0471799 into codepod-io:main Jun 10, 2023
@forrestbao
Copy link
Collaborator

Thanks @chimmyten. But the three options should appear in the output box instead of the code part.

Auto Hide Menu Changes

The new UI. Please let me know if I need to make additional changes.

@lihebi lihebi linked an issue Jun 10, 2023 that may be closed by this pull request
@lihebi
Copy link
Collaborator

lihebi commented Jun 10, 2023

We had a discussion in #321 about the menu position.

li-xin-yi pushed a commit to li-xin-yi/codepod-1 that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto hide of output box menus
3 participants