Skip to content

fix: dirty status on repo initial loading #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Jun 9, 2023

On repo's initial loading or refreshing, there were "dirty" pods that gets uploaded.

Screenshot 2023-06-08 at 18 20 04

There are three causes, all fixed:

  1. the auto-layout engine was run upon Code cell's running and layout states in useEffect, even if they are not changed. Now it is only triggered when the state is changed.
  2. There were dimension change events from reactflow's onNodeChange without actual change. Now this is filtered out.
  3. Rich text editor will fire a "change" event at the beginning. This is also filtered out.

@lihebi lihebi merged commit 6cdd844 into codepod-io:main Jun 9, 2023
li-xin-yi pushed a commit to li-xin-yi/codepod-1 that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant